Give release artifacts OS-scoped names and a Windows portable zip - #125
Merged
Conversation
Threadlines-0.3.1-x64.zip was the macOS updater archive, and Windows users browsing the releases page grabbed it by mistake; every artifact now carries its platform in the name. Windows nsis builds also produce a portable zip alongside the installer (the mac dmg+zip pairing, mirrored), which doubles as the artifact fresh-install audits can run without touching an installed copy. The Windows upload glob learned about zips, which it would otherwise have silently dropped; the release smoke asserts the new config; the marketing download classifier is pinned by its first test (new vitest wiring for apps/marketing).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artifact names gain their platform (Threadlines-${version}-${os}-${arch}.${ext}) so the macOS updater zips stop masquerading as Windows downloads on the releases page, and Windows nsis builds now pair with a portable zip (mirroring mac dmg+zip) — which also unblocks auditing desktop first-run from a real released artifact.
Notable: the Windows upload glob in release.yml would have silently dropped the zip (fixed); verified against electron-builder source that ${os} yields mac/win/linux and that the win zip does NOT enter latest.yml (so updater manifests stay exe-only); marketing's classifyAssets verified inert to the token and pinned by its first test (new vitest wiring for apps/marketing); release-smoke fixtures and assertions updated; stale pre-rebrand fixtures in merge-update-manifests.test.ts migrated.
Known limitation (unchanged): Windows builds are x64-only, so the portable zip is too.
Gates green; scripts 119 tests, marketing 2, release smoke assertions extended.