Skip to content

Fix: Tag Message Content preview does not render Markdown #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHall-1 merged 1 commit into from
Sep 4, 2026
Merged

Fix: Tag Message Content preview does not render Markdown #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions frontend/src/components/discord/DiscordEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,19 @@ const DiscordEmbedComponent: FC<DiscordEmbedProps> = ({ embed, entities, classNa
{embed.title && (
<div className="mb-2">
{embed.url && isSafeUrl(embed.url) ? (
<a
href={embed.url}
target="_blank"
rel="noopener noreferrer"
className="text-blue-400 hover:underline font-semibold text-lg"
>
{embed.title}
<a href={embed.url} target="_blank" rel="noopener noreferrer">
<DiscordContent
content={embed.title}
entities={entities}
className="text-blue-400! hover:underline font-semibold text-lg"
/>
</a>
) : (
<h3 className="text-white font-semibold text-lg">{embed.title}</h3>
<DiscordContent
content={embed.title}
entities={entities}
className="text-white font-semibold text-lg"
/>
)}
</div>
)}
Expand All @@ -76,7 +79,11 @@ const DiscordEmbedComponent: FC<DiscordEmbedProps> = ({ embed, entities, classNa
key={index}
className={field.inline ? "inline-block mr-4 mb-2 min-w-37.5 max-w-50" : "mb-2"}
>
<div className="text-white font-semibold text-sm mb-1">{field.name}</div>
<DiscordContent
content={field.name}
entities={entities}
className="text-white font-semibold text-sm mb-1"
/>
<DiscordContent
content={field.value}
entities={entities}
Expand Down
26 changes: 16 additions & 10 deletions frontend/src/components/modals/TagEditorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import ColourSelect from "@/components/ColourSelect";
import Collapsible from "@/components/Collapsible";
import EmbedFieldsEditor from "@/components/EmbedFieldsEditor";
import EmbedPreview from "@/components/EmbedPreview";
import DiscordContent from "@/components/discord/DiscordContent";
import DateTimePicker from "@/components/DateTimePicker";
import { useKBArticles } from "@/hooks/queries/useKB";
import { parseEmbedTimestamp, serializeEmbedTimestamp } from "@/lib/embed-timestamp";
Expand Down Expand Up @@ -161,6 +162,9 @@ const TagEditorModal: FC<TagEditorModalProps> = ({

const linkedArticle = kbArticleId != null ? kbArticles?.find((a) => a.id === kbArticleId) : null;

const hasContentPreview = content.trim().length > 0;
const hasArticlePreview = !!linkedArticle?.content?.trim();

const kbArticleOptions = (kbArticles ?? [])
.filter((a) => a.published)
.map((a) => ({
Expand Down Expand Up @@ -408,26 +412,28 @@ const TagEditorModal: FC<TagEditorModalProps> = ({
{linkToKB && linkedArticle ? (
<div className="mt-4">
<p className="text-xs text-gray-300 mb-2">Showing linked KB article preview:</p>
{linkedArticle.content && (
<p className="text-sm whitespace-pre-wrap bg-[#242429] rounded p-3 text-gray-200">
{linkedArticle.content}
</p>
{hasArticlePreview && (
<DiscordContent
content={linkedArticle.content ?? ""}
className="text-sm bg-[#242429] rounded p-3"
/>
)}
{!linkedArticle.content && (
{!hasArticlePreview && (
<p className="text-gray-300 text-sm">
Article has no text content (may use an embed).
</p>
)}
</div>
) : (
<>
{content && (
<p className="mt-4 text-sm whitespace-pre-wrap bg-[#242429] rounded p-3">
{content}
</p>
{hasContentPreview && (
<DiscordContent
content={content}
className="mt-4 text-sm bg-[#242429] rounded p-3"
/>
)}
{useEmbed && <EmbedPreview embed={embed} />}
{!content && !useEmbed && (
{!hasContentPreview && !useEmbed && (
<p className="mt-4 text-gray-300 text-sm">
Add message content or enable an embed to see a preview.
</p>
Expand Down
Loading