Fix: Widen embed fields and unlock textarea drag-to-resize - #134
Merged
Conversation
Two fixes to the embed builder. **Embed fields were cramped.** `EmbedFieldsEditor` laid Field Name and Field Value side-by-side with `md:grid-cols-2`, but the editor already sits in the left half of a page-level `md:grid-cols-2` editor|preview layout. Each input ended up at roughly a quarter of the content width. Field Name now stacks above Field Value, so both span the full editor column — about double the width. **Drag-to-resize did nothing.** The shared `Textarea` was `resize-y max-h-50 h-50`. In Tailwind v4 `h-50` and `max-h-50` are both `12.5rem`, so the max-height cap *equalled* the default height — the native resize grip could only shrink the box, never grow it. Dropping the cap makes textareas freely resizable. `h-50` stays, so the default rendered height is unchanged at 200px everywhere. The `Textarea` fix applies app-wide (19 importers), not just to embed fields — no textarea in the dashboard could be dragged taller before this. No call site passes a height-related class (`Textarea`'s `className` prop lands on the outer wrapper div, never on the `<textarea>`), so there is no call-site churn.
BenHall-1
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes to the embed builder.
Embed fields were cramped.
EmbedFieldsEditorlaid Field Name and Field Value side-by-side withmd:grid-cols-2, but the editor already sits in the left half of a page-levelmd:grid-cols-2editor|preview layout. Each input ended up at roughly a quarter of the content width. Field Name now stacks above Field Value, so both span the full editor column — about double the width.Drag-to-resize did nothing. The shared
Textareawasresize-y max-h-50 h-50. In Tailwind v4h-50andmax-h-50are both12.5rem, so the max-height cap equalled the default height — the native resize grip could only shrink the box, never grow it. Dropping the cap makes textareas freely resizable.h-50stays, so the default rendered height is unchanged at 200px everywhere.The
Textareafix applies app-wide (19 importers), not just to embed fields — no textarea in the dashboard could be dragged taller before this. No call site passes a height-related class (Textarea'sclassNameprop lands on the outer wrapper div, never on the<textarea>), so there is no call-site churn.Type of Change
Checklist