Skip to content

Fix: Widen embed fields and unlock textarea drag-to-resize - #134

Merged
BenHall-1 merged 1 commit into
masterfrom
embed-fields-size-fix
Sep 4, 2026
Merged

Fix: Widen embed fields and unlock textarea drag-to-resize#134
BenHall-1 merged 1 commit into
masterfrom
embed-fields-size-fix

Conversation

@biast12

@biast12 biast12 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

Two fixes to the embed builder.

Embed fields were cramped. EmbedFieldsEditor laid Field Name and Field Value side-by-side with md:grid-cols-2, but the editor already sits in the left half of a page-level md:grid-cols-2 editor|preview layout. Each input ended up at roughly a quarter of the content width. Field Name now stacks above Field Value, so both span the full editor column — about double the width.

Drag-to-resize did nothing. The shared Textarea was resize-y max-h-50 h-50. In Tailwind v4 h-50 and max-h-50 are both 12.5rem, so the max-height cap equalled the default height — the native resize grip could only shrink the box, never grow it. Dropping the cap makes textareas freely resizable. h-50 stays, so the default rendered height is unchanged at 200px everywhere.

The Textarea fix applies app-wide (19 importers), not just to embed fields — no textarea in the dashboard could be dragged taller before this. No call site passes a height-related class (Textarea's className prop lands on the outer wrapper div, never on the <textarea>), so there is no call-site churn.

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Two fixes to the embed builder.

**Embed fields were cramped.** `EmbedFieldsEditor` laid Field Name and Field Value side-by-side with `md:grid-cols-2`, but the editor already sits in the left half of a page-level `md:grid-cols-2` editor|preview layout. Each input ended up at roughly a quarter of the content width. Field Name now stacks above Field Value, so both span the full editor column — about double the width.

**Drag-to-resize did nothing.** The shared `Textarea` was `resize-y max-h-50 h-50`.
In Tailwind v4 `h-50` and `max-h-50` are both `12.5rem`, so the max-height cap *equalled* the default height — the native resize grip could only shrink the box, never grow it. Dropping the cap makes textareas freely resizable. `h-50` stays, so the default rendered height is unchanged at 200px everywhere.

The `Textarea` fix applies app-wide (19 importers), not just to embed fields — no textarea in the dashboard could be dragged taller before this. No call site passes a height-related class (`Textarea`'s `className` prop lands on the outer wrapper div, never on the `<textarea>`), so there is no call-site churn.
@biast12
biast12 requested a review from a team as a code owner August 31, 2026 21:05
@github-actions github-actions Bot added the type:bug Bug Fixes label Aug 31, 2026
@BenHall-1
BenHall-1 merged commit c63e1cf into master Sep 4, 2026
3 checks passed
@BenHall-1
BenHall-1 deleted the embed-fields-size-fix branch September 4, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants