Skip to content

Fix: Awaiting Response Category cannot be unset - #138

Merged
BenHall-1 merged 1 commit into
masterfrom
awaiting-response-category-none
Sep 5, 2026
Merged

Fix: Awaiting Response Category cannot be unset#138
BenHall-1 merged 1 commit into
masterfrom
awaiting-response-category-none

Conversation

@biast12

@biast12 biast12 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Once a panel's Awaiting Response Category was set, there was no way to unset it — the dropdown had no "None" entry, so the only escape was deleting the Discord category.

The backend already supported unset (pending_category is nullable, and validatePendingCategory returns nil early when the value is nil), so this was a UI gap.

It also caused a save lock-out: validation.go:277 rejects a non-nil value for non-premium guilds, but the dropdown was disabled for those guilds. A server whose premium lapsed with a category set could not save any edit to that panel, with no way to clear the offending field.

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

Set Awaiting Response Category to the none value

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Panel creation now checks premium quota and premium feature access separately, so voting premium can unlock premium-only fields without increasing panel quota. In create/edit panel pages, Awaiting Response Category now uses the voting-aware premium state, shows a crown hint when locked, supports an explicit "none" option, and stores `pending_category` as nullable to match the UI behavior.
@biast12
biast12 requested a review from a team as a code owner September 4, 2026 22:21
@github-actions github-actions Bot added the type:bug Bug Fixes label Sep 4, 2026
@BenHall-1
BenHall-1 merged commit 1c019a5 into master Sep 5, 2026
3 checks passed
@BenHall-1
BenHall-1 deleted the awaiting-response-category-none branch September 5, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants