Fix: Awaiting Response Category cannot be unset - #138
Merged
Conversation
Panel creation now checks premium quota and premium feature access separately, so voting premium can unlock premium-only fields without increasing panel quota. In create/edit panel pages, Awaiting Response Category now uses the voting-aware premium state, shows a crown hint when locked, supports an explicit "none" option, and stores `pending_category` as nullable to match the UI behavior.
BenHall-1
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Once a panel's Awaiting Response Category was set, there was no way to unset it — the dropdown had no "None" entry, so the only escape was deleting the Discord category.
The backend already supported unset (
pending_categoryis nullable, andvalidatePendingCategoryreturns nil early when the value is nil), so this was a UI gap.It also caused a save lock-out:
validation.go:277rejects a non-nil value for non-premium guilds, but the dropdown wasdisabledfor those guilds. A server whose premium lapsed with a category set could not save any edit to that panel, with no way to clear the offending field.Type of Change
Testing
Set Awaiting Response Category to the none value
Checklist