Fix onboarding permission checks and stale state - #139
Open
biast12 wants to merge 1 commit into
Open
Conversation
Avoid spurious error toasts and stale onboarding data. API: mark onboarding GET as admin-only (SKIP_ERROR_TOAST) and accept optional Axios config for POST. GuildLayout: reset onboarding store on guild change, and only show the banner for admins (permission_level >= 2). SetupLayout: pre-check cached permission and redirect non-admins. OnboardingBanner: ignore stale store entries by checking state.guild_id and use SKIP_ERROR_TOAST when dismissing the banner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GuildLayout: reset onboarding store on guild change, and only show the banner for admins (permission_level >= 2). SetupLayout: pre-check cached permission and redirect non-admins. OnboardingBanner: ignore stale store entries by checking state.guild_id and use SKIP_ERROR_TOAST when dismissing the banner.
Type of Change
Checklist