Fix: Render KB embed text in article views - #149
Open
biast12 wants to merge 1 commit into
Open
Conversation
KB article rendering now includes stored embed description/fields in the message body (within a text budget) and uses safer embed access helpers to avoid nil-pointer edge cases. Article views also show a no-description placeholder only when nothing at all can be rendered, while preserving image rendering and button behavior. Additionally, the outdated /kb send TODO was removed, and ticket reopen limit replies now pass pluralized limit arguments with error styling.
BenHall-1
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
KB article rendering now includes stored embed description/fields in the message body (within a text budget) and uses safer embed access helpers to avoid nil-pointer edge cases. Article views also show a no-description placeholder only when nothing at all can be rendered, while preserving image rendering and button behavior. Additionally, the outdated /kb send TODO was removed, and ticket reopen limit replies now pass pluralized limit arguments with error styling.
Type of Change
Testing
Do not have any kb categories
Use the
/kb browsecommand - you should not see the "%!(EXTRA []interface {}=[])" at the end of the messageUse the command again, this time with a kb category and a kb article
The article should not have any content other than a description and an embed
Checklist