ci: give the examples job the test data it needs - #62
Merged
Conversation
Four examples were reported as smoke failures in CI while passing locally:
file_cte, cte_demo, expansion_transformers and mathematical_series. All four
load a data file that exists in a developer's working tree but never in a
fresh checkout, because .gitignore's blanket `test_*.csv` rule covers it.
file_cte: Query 1 failed: File not found: data/test_simple_strings.csv
Two fixes, one per cause:
- data/test_simple_{math,strings}.csv are generated by
scripts/generate_simple_test.py. The Python Tests job already runs that
script; the Examples job never did. Add the same step there.
- data/test_dummy.csv is a hand-written three-row fixture that no script
generates, so generating it is not an option - it has to ship. Un-ignore
and commit it.
Note this was never gating the build: test_examples.py exits non-zero only
for FORMAL failures (those with an examples/expectations/*.json), so these
were noise in an otherwise green job. The remaining 18 smoke failures
reproduce locally too - 6 need a live HTTP endpoint, 12 are genuine engine
or example bugs - and are left alone here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four examples were reported as smoke failures in CI while passing locally: file_cte, cte_demo, expansion_transformers and mathematical_series. All four load a data file that exists in a developer's working tree but never in a fresh checkout, because .gitignore's blanket
test_*.csvrule covers it.file_cte: Query 1 failed: File not found: data/test_simple_strings.csv
Two fixes, one per cause:
data/test_simple_{math,strings}.csv are generated by scripts/generate_simple_test.py. The Python Tests job already runs that script; the Examples job never did. Add the same step there.
data/test_dummy.csv is a hand-written three-row fixture that no script generates, so generating it is not an option - it has to ship. Un-ignore and commit it.
Note this was never gating the build: test_examples.py exits non-zero only for FORMAL failures (those with an examples/expectations/*.json), so these were noise in an otherwise green job. The remaining 18 smoke failures reproduce locally too - 6 need a live HTTP endpoint, 12 are genuine engine or example bugs - and are left alone here.