Add hover tooltips to social buttons; update Stack Overflow icon - #85
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Hover tooltips on the social buttons (
Social.tsx)aria-labels — they previously had no accessible names.Layout.tsx) so the caption stays inside it instead of extending the page height on hover.New Stack Overflow icon (
StackOverflow.tsx)Notes for review
/uses(and possibly/) are intentionally stale — the footer is taller and the icon changed. Expect theupdate-snapshotsCI job to push a snapshot-refresh commit to this branch after the first test run.yarn buildpasses; the only Playwright failures are the known stale snapshots above plus the pre-existinghomemobile rendering drift on macOS.