Skip to content

Feature/update link - #104

Merged
RishabhS7 merged 2 commits into
developfrom
feature/update-link
Aug 12, 2026
Merged

Feature/update link#104
RishabhS7 merged 2 commits into
developfrom
feature/update-link

Conversation

@manishdex25

@manishdex25 manishdex25 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Replaced the Partners navigation item with a responsive Verticals dropdown linking to TradeTrust, OpenCerts, and SAL.
    • Added improved desktop and mobile menu interactions, including outside-click dismissal and accessible expanded states.
  • Bug Fixes

    • Updated TrustVC documentation links to the new documentation site.
  • Removals

    • Removed the Partners page, route, and homepage section.

isaackps and others added 2 commits August 6, 2026 14:51
#97) (#101)

* feat: replace Partners tab with Verticals dropdown and remove partners page

- Navbar Partners tab is now a Verticals dropdown (desktop + mobile) linking
  to TradeTrust, OpenCerts, and SAL, opening in new tabs
- Remove /partners route and PartnersSection from Home
- Pin @trustvc/trustvc to 2.15.0-beta.2 in lockfile



* test: update navbar and home tests for Verticals dropdown

- Navbar/App tests: expect Verticals instead of removed Partners tab
- Add Verticals dropdown test asserting TradeTrust/OpenCerts/SAL links
- Drop Home Partners-section tests (section removed)



* fix: keep mobile Verticals submenu interactions contained on outside-click

The document mousedown handler closed the Verticals dropdown whenever the
target was outside the desktop dropdown container, so taps on the mobile
submenu (links and toggle) unmounted the target before click fired. Track
the mobile menu with its own ref and treat clicks inside either container
as contained.



---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c3883ab-d9c8-4544-8cf9-07b3d2d8f5a2

📥 Commits

Reviewing files that changed from the base of the PR and between 0dd9acd and 80f4426.

📒 Files selected for processing (9)
  • src/App.test.tsx
  • src/__tests__/home.test.tsx
  • src/components/common/Navbar/Navbar.test.tsx
  • src/components/common/Navbar/Navbar.tsx
  • src/components/home/BuiltForDev/BuiltForDev.test.tsx
  • src/components/home/BuiltForDev/BuiltForDev.tsx
  • src/components/home/VerifySection/VerifyError.tsx
  • src/pages/Home/index.tsx
  • src/routes.tsx

📝 Walkthrough

Walkthrough

The navbar replaces Partners with responsive Verticals menus linking to TradeTrust, OpenCerts, and SAL. The Partners route and home section are removed. TrustVC documentation links now use docs.trustvc.io.

Changes

Verticals navigation

Layer / File(s) Summary
Responsive Verticals menu
src/components/common/Navbar/Navbar.tsx, src/components/common/Navbar/Navbar.test.tsx, src/App.test.tsx
The navbar adds desktop and mobile Verticals menus with external links, accessibility state, outside-click handling, and menu-closing behavior. Tests cover the new links and mobile flow.
Partners route and home removal
src/routes.tsx, src/pages/Home/index.tsx, src/__tests__/home.test.tsx
The Partners route and home section are removed. Related tests no longer validate the Partners section.
TrustVC documentation links
src/components/home/BuiltForDev/BuiltForDev.tsx, src/components/home/BuiltForDev/BuiltForDev.test.tsx, src/components/home/VerifySection/VerifyError.tsx
Documentation links and their test expectation now use https://docs.trustvc.io.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Visitor
  participant Navbar
  participant ExternalSite
  Visitor->>Navbar: Open Verticals menu
  Navbar-->>Visitor: Show external links
  Visitor->>Navbar: Select a vertical
  Navbar->>ExternalSite: Open link in a new tab
  Navbar-->>Visitor: Close menu
Loading

Possibly related PRs

Suggested reviewers: isaackps, rishabhs7

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/update-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@manishdex25
manishdex25 requested a review from RishabhS7 August 12, 2026 10:52
@RishabhS7
RishabhS7 merged commit c88a5ae into develop Aug 12, 2026
5 checks passed
@RishabhS7
RishabhS7 deleted the feature/update-link branch August 12, 2026 17:57
rongquan1 pushed a commit that referenced this pull request Aug 13, 2026
* feat: replace Partners tab with Verticals dropdown and remove partner… (#97)

* feat: replace Partners tab with Verticals dropdown and remove partners page

- Navbar Partners tab is now a Verticals dropdown (desktop + mobile) linking
  to TradeTrust, OpenCerts, and SAL, opening in new tabs
- Remove /partners route and PartnersSection from Home
- Pin @trustvc/trustvc to 2.15.0-beta.2 in lockfile

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test: update navbar and home tests for Verticals dropdown

- Navbar/App tests: expect Verticals instead of removed Partners tab
- Add Verticals dropdown test asserting TradeTrust/OpenCerts/SAL links
- Drop Home Partners-section tests (section removed)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: keep mobile Verticals submenu interactions contained on outside-click

The document mousedown handler closed the Verticals dropdown whenever the
target was outside the desktop dropdown container, so taps on the mobile
submenu (links and toggle) unmounted the target before click fired. Track
the mobile menu with its own ref and treat clicks inside either container
as contained.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* Feature/boe v2 (#100)

* feat: added integration for the trustvc sdk for the BOE beta version

* feat: updated package json

* feat: udpate the bligation functions for etr

* feat: fix coderabbit issues

* feat: integrate obligation handling in AssetManagement components

- Added isObligation prop to DocumentStatus and AssetManagementTags components to manage obligation-specific UI behavior.
- Enhanced ActionSelectionForm to display obligation status labels and manage visibility based on isObligation state.

* feat: fix overflow of the dropdown container

* chore: update @trustvc/trustvc and related dependencies to version 2.16.0-beta.3 and 2.4.2 in package.json and package-lock.json

* chore: update @trustvc/trustvc and related dependencies to version 2.16.0-beta.3 and 2.4.2 in package.json and package-lock.json (#102)

* chore: update package-lock.json to include new dependencies for @trustvc/trustvc

* Feature/update link (#104)

* feat: replace Partners tab with Verticals dropdown and remove partner… (#97) (#101)

* feat: replace Partners tab with Verticals dropdown and remove partners page

- Navbar Partners tab is now a Verticals dropdown (desktop + mobile) linking
  to TradeTrust, OpenCerts, and SAL, opening in new tabs
- Remove /partners route and PartnersSection from Home
- Pin @trustvc/trustvc to 2.15.0-beta.2 in lockfile



* test: update navbar and home tests for Verticals dropdown

- Navbar/App tests: expect Verticals instead of removed Partners tab
- Add Verticals dropdown test asserting TradeTrust/OpenCerts/SAL links
- Drop Home Partners-section tests (section removed)



* fix: keep mobile Verticals submenu interactions contained on outside-click

The document mousedown handler closed the Verticals dropdown whenever the
target was outside the desktop dropdown container, so taps on the mobile
submenu (links and toggle) unmounted the target before click fired. Track
the mobile menu with its own ref and treat clicks inside either container
as contained.



---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* feat: update links

---------

Co-authored-by: isaackps <isaac.kps.work@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: isaackps <isaac.kps.work@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants