Skip to content

feat: fix the gasles signer and coverage for document loaded for obli… - #106

Closed
manishdex25 wants to merge 1 commit into
developfrom
feature/fix-develop
Closed

feat: fix the gasles signer and coverage for document loaded for obli…#106
manishdex25 wants to merge 1 commit into
developfrom
feature/fix-develop

Conversation

@manishdex25

@manishdex25 manishdex25 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

…gation

Summary by CodeRabbit

  • Bug Fixes
    • Added wallet-network validation before gasless and title-escrow transactions are submitted.
    • Prevented transactions from being sent when the wallet is connected to the wrong document network.
    • Improved document verification when the network is missing by prompting for network selection instead of failing immediately.
    • Preserved document filenames during network selection and ensured verification continues with the selected network.
    • Improved error reporting when network validation fails.

@manishdex25
manishdex25 requested a review from RishabhS7 August 13, 2026 05:40
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f956b85-d946-4d51-a580-0220d3dfd6f6

📥 Commits

Reviewing files that changed from the base of the PR and between c88a5ae and 5f028fa.

📒 Files selected for processing (5)
  • src/components/common/contexts/TokenInformationContext/TokenInformationContext.tsx
  • src/components/home/VerifySection/useVerify.test.ts
  • src/components/home/VerifySection/useVerify.ts
  • src/gasless/gaslessHooks.test.tsx
  • src/gasless/makeGaslessHook.ts

📝 Walkthrough

Walkthrough

The change resolves verification chains from document data, selects a network when needed, and adds signer-chain preflight validation to gasless token and obligation writes.

Changes

Document-chain validation

Layer / File(s) Summary
Verification chain resolution
src/components/home/VerifySection/useVerify.ts, src/components/home/VerifySection/useVerify.test.ts
loadDocument resolves an explicit, document, or embedded chain. It enters network-select when blockchain verification needs a chain. Tests cover obligation documents without a chain ID.
Gasless obligation preflight
src/gasless/makeGaslessHook.ts, src/gasless/gaslessHooks.test.tsx
Obligation writes run an optional preflight callback before submission. Tests cover rejected and successful preflight checks.
Signer-chain preflight wiring
src/components/common/contexts/TokenInformationContext/TokenInformationContext.tsx
Gasless token and title-escrow write hooks receive assertSignerOnDocumentChain and documentChainId.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 5f028

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

Suggested reviewers: rishabhs7

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the gasless signer fix and obligation document coverage, which match the main changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/fix-develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@manishdex25 manishdex25 self-assigned this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant