Feature/boe fix on shred - #157
Conversation
…est.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…emarkEscrowMethod
…and obligation record verifier
… in obligation registry utility
…date event handling
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…gation registry functions
…ntroducing EthersError type
…ionRecordVerifier.types.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/__tests__/verify/obligationRecordVerifier.utils.test.ts (1)
25-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRename the test to match the registry-only assertion.
The test no longer verifies an active title or escrow state. It verifies that a non-zero
ownerOfresult is minted.Proposed test-name update
- it('returns minted when owner is set (active title)', async () => { + it('returns minted when owner is set (non-zero owner)', async () => {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/__tests__/verify/obligationRecordVerifier.utils.test.ts` around lines 25 - 28, Rename the test case around mockOwnerOf and the ownerOf assertion to describe that a non-zero ownerOf result is minted, removing references to active titles, escrow, or owner state.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/__tests__/verify/obligationRecordVerifier.utils.test.ts`:
- Around line 25-28: Rename the test case around mockOwnerOf and the ownerOf
assertion to describe that a non-zero ownerOf result is minted, removing
references to active titles, escrow, or owner state.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a266ca9b-7498-44df-9f9a-69f51f8d56b3
📒 Files selected for processing (2)
src/__tests__/verify/obligationRecordVerifier.utils.test.tssrc/verify/fragments/document-status/obligationRecords/utils.ts
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 24: Update the package.json prepare script so production installs without
devDependencies do not fail when tsup or husky are unavailable. Make the build
and Husky setup conditional or otherwise skip them in that environment, while
preserving their execution for development installs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0504f177-fa85-4a6f-b819-d24cd7f964fa
📒 Files selected for processing (2)
README.mdpackage.json
|
## [2.15.0-beta.4](v2.15.0-beta.3...v2.15.0-beta.4) (2026-08-03) ### Bug Fixes * boe fix on shred ([#157](#157)) ([a635cfc](a635cfc))
|
🎉 This PR is included in version 2.15.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [2.16.0-beta.1](v2.15.0...v2.16.0-beta.1) (2026-08-03) ### Features * add EIP-7702 gasless functions with full test coverage ([e8d8b21](e8d8b21)) * **eip7702:** export contract ABIs via eip7702Abis from @trustvc/trustvc ([59531e8](59531e8)) * implement obligation registry functions and enhance document bu… ([#155](#155)) ([2a3cf11](2a3cf11)) ### Bug Fixes * add --legacy-peer-deps to npm ci in all workflows ([44fa8ef](44fa8ef)) * boe fix on shred ([#157](#157)) ([a635cfc](a635cfc)) * boe heap issue ([#156](#156)) ([b997db7](b997db7)) ### Miscellaneous Chores * **release:** 2.15.0-beta.1 [skip ci] ([726e6a0](726e6a0)) * **release:** 2.15.0-beta.2 [skip ci] ([bc3eba0](bc3eba0)) * **release:** 2.15.0-beta.3 [skip ci] ([0f56031](0f56031)), closes [#155](#155) [#156](#156) * **release:** 2.15.0-beta.4 [skip ci] ([6c3668f](6c3668f)), closes [#157](#157) * replace local eip7702 file ref with npm package @trustvc/eip7702@^1.0.0-beta.1 ([bc81fb5](bc81fb5))
|
🎉 This PR is included in version 2.16.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Summary
What is the background of this pull request?
Changes
Issues
What are the related issues or stories?
Summary by CodeRabbit
Bug Fixes
Documentation
Chores