You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is "translation_function_name": "__" for? It doesn't seem to be used anywhere.
I wonder if it's possible to design this as a weak dependency so that if tap is not part of the package, the _ helper just pulls out the English text by default. Or do you think that is worth it?
Hi @guidouil - I apologize for the extremely long delay on this.
I have been too busy to maintain this project effectively, so I gave you commit access to make any changes you'd like. It would be nice to follow the style used by the rest of the code and add some tests to this patch.
If you'd like permission to publish the package to Meteor as well, please send me your Meteor developer username.
If you'd like permission to publish the package to Meteor as well, please send me your Meteor developer username.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So here it is, the text in english is yours and I did add the package, it's files and the french translation.
Thanks