Bugfixes regarding adding controls in the sizer - #553
Merged
Conversation
mojie126
added a commit
to mojie126/Aegisub
that referenced
this pull request
Feb 28, 2026
- 移除border=0时无效的方向标志(wxALL/wxRIGHT/wxLEFT/wxBOTTOM等) - 移除wxCENTER与wxEXPAND的矛盾组合 - dialog_jumpto: wxGridSizer改为wxFlexGridSizer修复布局错位 - preferences: 修复颜色方案面板比例分配 - preferences_base: 浏览/字体按钮改用CenterVertical()对齐 - 跳过subs_edit_box.cpp(已有独立重写)
mojie126
added a commit
to mojie126/Aegisub
that referenced
this pull request
Mar 19, 2026
- 移除border=0时无效的方向标志(wxALL/wxRIGHT/wxLEFT/wxBOTTOM等) - 移除wxCENTER与wxEXPAND的矛盾组合 - dialog_jumpto: wxGridSizer改为wxFlexGridSizer修复布局错位 - preferences: 修复颜色方案面板比例分配 - preferences_base: 浏览/字体按钮改用CenterVertical()对齐 - 跳过subs_edit_box.cpp(已有独立重写)
…when the border width is 0
…when the border direction is not specified
wxEXPAND overrides alignment flags in box sizers
The text *inside* a vertically stretched text control is not vertically centered itself, so instead leave the text controls unstretched and center them vertically in their container.
Otherwise the control is only a single character wide on Mac.
arch1t3cht
force-pushed
the
sizer-bugfix-1
branch
from
July 11, 2026 18:42
e569b75 to
92858dd
Compare
Member
|
Rebased, squashed three of the commits together, and added a fix for another bug I found while testing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My local repo is currently too messy, so I've decided to split that massive PR #512 and first incorporate some bugfixes into the upstream.
Of these commits, 1e747f6 aims to fix the following problem: