Add exe installer - #247
Open
goku-kamehameha wants to merge 6 commits into
Open
Conversation
…pdate version to 6.0.3+292
… version to 5.9.0+290
goku-kamehameha
requested review from
JuliusCaesarCrypto
and
a lite review from Copilot
and removed request for
Copilot
August 23, 2026 11:57
There was a problem hiding this comment.
Pull request overview
Adds a Windows x64 EXE installer using Inno Setup, replacing the previous MSIX packaging flow.
Changes:
- Adds an Inno Setup installer with bundled VC++ runtime.
- Updates Windows CI and release links for the
.exeartifact. - Removes MSIX configuration, dependencies, and version handling.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Summary / Findings |
|---|---|
windows/installer/defyx_vpn.iss |
Defines the installer. Moderate (2 votes): Startup registration does not quote the executable path, breaking launch from paths containing spaces. |
scripts/setup/version.sh |
Removes MSIX version updates. |
pubspec.yaml |
Removes MSIX configuration. |
pubspec.lock |
Removes MSIX-related dependencies. |
.github/workflows/windows.yml |
Builds and uploads the EXE installer. |
.github/workflows/build.yml |
Formatting-only workflow changes. |
.github/release_message.md |
Updates the installer link. Moderate (2 votes): Existing releases may retain a stale .msix link because the release body is not regenerated. |
Suppressed comments (1)
windows/installer/defyx_vpn.iss:57
- The app creates
HKCU\Software\Microsoft\Windows\CurrentVersion\Run\DefyxVPNwhen launch-on-startup is enabled (windows/runner/registry_manager.cpp:23-35), but this installer has no uninstall cleanup for that value. Uninstalling after enabling the option removes the executable while leaving Windows to try launching the missing path at every login. Add an uninstall-time deletion for that exact Run value.
[Run]
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <br /> | ||
| <a | ||
| href="https://github.com/UnboundTechCo/defyxVPN/releases/download/RELEASE_TAG/DefyxVPN-Windows-Installer-x64.msix"> | ||
| href="https://github.com/UnboundTechCo/defyxVPN/releases/download/RELEASE_TAG/DefyxVPN-Windows-Installer-x64.exe"> |
| AppName={#MyAppName} | ||
| AppVersion={#MyAppVersion} | ||
| AppPublisher={#MyAppPublisher} | ||
| DefaultDirName={autopf}\{#MyAppName} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Briefly describe what this PR does and why. Keep it short and clear.
Related Platforms
Verification Checklist
Optional (for bigger changes)
Related Links
Closes #ID.