Skip to content

Add exe installer - #247

Open
goku-kamehameha wants to merge 6 commits into
devfrom
add-exe-installer
Open

Add exe installer#247
goku-kamehameha wants to merge 6 commits into
devfrom
add-exe-installer

Conversation

@goku-kamehameha

Copy link
Copy Markdown
Contributor

Change Description

Briefly describe what this PR does and why. Keep it short and clear.


Related Platforms

Which platforms are affected by your changes? Check only the ones you actually tested.

  • Android
  • iOS
  • iPad
  • Windows
  • Linux
  • Android TV
  • OpenWrt

Verification Checklist

Make sure the things you checked actually work. It's okay if you didn't test everything.

  • Project builds successfully
  • App runs without crashes on tested platforms
  • VPN connection works correctly
  • No obvious regressions observed
  • Documentation updated (if needed)

Optional (for bigger changes)

  • Added or updated unit / E2E tests
  • Checked security and edge cases

Related Links

Closes #ID.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Windows x64 EXE installer using Inno Setup, replacing the previous MSIX packaging flow.

Changes:

  • Adds an Inno Setup installer with bundled VC++ runtime.
  • Updates Windows CI and release links for the .exe artifact.
  • Removes MSIX configuration, dependencies, and version handling.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Summary / Findings
windows/installer/defyx_vpn.iss Defines the installer. Moderate (2 votes): Startup registration does not quote the executable path, breaking launch from paths containing spaces.
scripts/setup/version.sh Removes MSIX version updates.
pubspec.yaml Removes MSIX configuration.
pubspec.lock Removes MSIX-related dependencies.
.github/workflows/windows.yml Builds and uploads the EXE installer.
.github/workflows/build.yml Formatting-only workflow changes.
.github/release_message.md Updates the installer link. Moderate (2 votes): Existing releases may retain a stale .msix link because the release body is not regenerated.
Suppressed comments (1)

windows/installer/defyx_vpn.iss:57

  • The app creates HKCU\Software\Microsoft\Windows\CurrentVersion\Run\DefyxVPN when launch-on-startup is enabled (windows/runner/registry_manager.cpp:23-35), but this installer has no uninstall cleanup for that value. Uninstalling after enabling the option removes the executable while leaving Windows to try launching the missing path at every login. Add an uninstall-time deletion for that exact Run value.
[Run]

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

<br />
<a
href="https://github.com/UnboundTechCo/defyxVPN/releases/download/RELEASE_TAG/DefyxVPN-Windows-Installer-x64.msix">
href="https://github.com/UnboundTechCo/defyxVPN/releases/download/RELEASE_TAG/DefyxVPN-Windows-Installer-x64.exe">
AppName={#MyAppName}
AppVersion={#MyAppVersion}
AppPublisher={#MyAppPublisher}
DefaultDirName={autopf}\{#MyAppName}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants