Skip to content

trunk shadow changes: com.unity.probuilder - #695

Open
pets-svc[bot] wants to merge 14 commits into
masterfrom
shadow-package/com.unity.probuilder
Open

trunk shadow changes: com.unity.probuilder#695
pets-svc[bot] wants to merge 14 commits into
masterfrom
shadow-package/com.unity.probuilder

Conversation

@pets-svc

@pets-svc pets-svc Bot commented Aug 8, 2026

Copy link
Copy Markdown

This PR contains changes made to the trunk copy of com.unity.probuilder.

This usually means that breaking changes has landed in the trunk Editor, necessitating matching changes to your package code. trunk is therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package, release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.

If this PR contains unexpected changes, first make sure the PR target branch is set correctly. If not, change it by clicking the pencil icon next to the PR title.

Visit #devs-pets if you have questions about shadow packages or this automation.

Note: The shadow-package/com.unity.probuilder branch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:

git fetch origin shadow-package/com.unity.probuilder:mybranch
git checkout mybranch

If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.

@cla-assistant-unity

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lopezt-unity
❌ pets-svc[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The import-time guard prevents the original null dereference but leaves cached toolbar controls unable to recover once the UXML asset becomes available.

Reviewed commit 8f6fdbb

🤖 Helpful? 👍/👎


internal void UpdateContentForToolbar(Layout layout)
{
if (!m_Initialized)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

When the UXML load fails during the import-time state this change is handling, RefreshAvailableActions has already created and cached m_ActionButtons. Bind stores each action but does not wire it up while uninitialized; subsequent refreshes only hide/show those instances, and UpdateToolbar reaches this early return without ever retrying Bind. Thus opening the horizontal or vertical toolbar after the asset database recovers leaves empty, non-clickable controls for the lifetime of that overlay instance. Retry and complete binding for cached buttons once the template is available (or recreate them); grid items already recover because BindItem calls Bind again.

🤖 Helpful? 👍/👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant