trunk shadow changes: com.unity.probuilder - #695
Conversation
# Conflicts: # .yamato/wrench/preview-a-p-v.yml # .yamato/wrench/validation-jobs.yml
Co-authored-by: u-pr[bot] <205906871+u-pr[bot]@users.noreply.github.com>
…/6.1 # Conflicts: # CHANGELOG.md # package.json
|
|
|
|
||
| internal void UpdateContentForToolbar(Layout layout) | ||
| { | ||
| if (!m_Initialized) |
There was a problem hiding this comment.
When the UXML load fails during the import-time state this change is handling, RefreshAvailableActions has already created and cached m_ActionButtons. Bind stores each action but does not wire it up while uninitialized; subsequent refreshes only hide/show those instances, and UpdateToolbar reaches this early return without ever retrying Bind. Thus opening the horizontal or vertical toolbar after the asset database recovers leaves empty, non-clickable controls for the lifetime of that overlay instance. Retry and complete binding for cached buttons once the template is available (or recreate them); grid items already recover because BindItem calls Bind again.
🤖 Helpful? 👍/👎
This PR contains changes made to the
trunkcopy ofcom.unity.probuilder.This usually means that breaking changes has landed in the
trunkEditor, necessitating matching changes to your package code.trunkis therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package, release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.If this PR contains unexpected changes, first make sure the PR target branch is set correctly. If not, change it by clicking the
next to the PR title.
Visit #devs-pets if you have questions about shadow packages or this automation.
Note: The
shadow-package/com.unity.probuilderbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.