fix(rest/python): serve the discovery profile with a Cache-Control header - #153
Merged
damaz91 merged 1 commit intoJul 30, 2026
Conversation
…ader The discovery profile at /.well-known/ucp was returned with no Cache-Control header. The spec requires profile responses to be cacheable (overview.md, Discovery: profile caching): Profile responses MUST include a Cache-Control header with `public` and `max-age` of at least 60 seconds. Profiles MUST NOT be served with `private`, `no-store`, or `no-cache` directives. Set `Cache-Control: public, max-age=3600` on the profile response, and add an integration test asserting the header is present, `public`, carries a `max-age` >= 60, and uses none of the forbidden directives. Verified: new test fails on the current handler and passes with the fix; the full integration suite stays green; and a booted server returns the header on the wire.
nicholasjameshall
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The discovery profile at
/.well-known/ucpis returned with noCache-Controlheader. The spec requires profile responses to be cacheable (overview.md, Discovery: profile caching):This PR sets
Cache-Control: public, max-age=3600on the profile response and adds an integration test asserting the header is present,public, carries amax-age>= 60, and uses none of the forbidden directives.Verified locally: the new test fails on the current handler and passes with the fix; the full
rest/python/serverintegration suite stays green; and a booted server returns the header on the wire.Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Checklist
!for breaking changes).