feat: add font size keyboard shortcuts - #513
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe keyboard handler now changes font size by one for active text selections and selected textbox components. It validates text mode, active styles, component types, and finite font-size values. ChangesFont-size keyboard shortcuts
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adds font-size keyboard shortcuts without any actionable merge-blocking risk remaining; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant User
participant KeyboardShortcuts
participant TextSelection
participant TextboxComponent
User->>KeyboardShortcuts: Press mod+shift+> or mod+shift+<
KeyboardShortcuts->>TextSelection: Adjust active text style when text is selected
KeyboardShortcuts->>TextboxComponent: Adjust font size when a textbox is selected
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
harbassan
requested changes
Sep 1, 2026
harbassan
left a comment
harbassan
left a comment
Contributor
There was a problem hiding this comment.
just this one change, once its adressed feel free to merge
Comment on lines
+186
to
+195
| { | ||
| combos: ["ctrl+shift+>"], | ||
| when: canAdjustSelectedTextFontSize, | ||
| run: () => adjustSelectedTextFontSize(1), | ||
| }, | ||
| { | ||
| combos: ["ctrl+shift+<"], | ||
| when: canAdjustSelectedTextFontSize, | ||
| run: () => adjustSelectedTextFontSize(-1), | ||
| }, |
Contributor
There was a problem hiding this comment.
this should be mod instead of ctrl so that its cross device compatible
…y ids to SidePanel
* feat: show just icon and label in side panel * feat: add reusable authoring side panel * feat: implement side panel * feat: implement side panel to object property editor * feat: center sidebar icons vertically * feat: add animation * fix: prettier * fix: guard sidebar animation if API is unavailable * feat: expand canvas when sidebar panel is closed * fix: adjust icon sizes * feat: make icons seem clickable * fix: preserve keyboard tab order in side panels * fix: use useLayoutEffect as suggested by CodeRabbit * fix: refresh canvas sidebar position on panel changes * fix: adjust button size * fix: reorder side panel to natural order * restore side panel keyboard tab order # Conflicts: # frontend/src/features/authoring/CanvasSideBar/SidePanel.jsx * fix: prettier * fix: prettier * fix: restore side panel keyboard tab order * fix: fix animation when an icon is selected * fix: prettier * Fix CodeRabbit issues in PR #518 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
harbassan
approved these changes
Sep 2, 2026
harbassan
force-pushed
the
master
branch
3 times, most recently
from
September 2, 2026 06:16
d1754f4 to
4b66f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The authoring tool does not provide keyboard shortcuts for adjusting text font size. Authors must use the toolbar controls even when text or a textbox is already selected.
Solution
Ctrl+Shift+>to increase font size by one.Ctrl+Shift+<to decrease font size by one.Risk
Low. The change is limited to the authoring shortcut registry and reuses the existing text styling and history paths. The shortcuts only run when at least one textbox is selected.
Testing
npx.cmd prettier --check src/features/authoring/handlers/keyboard/shortcuts.tsnpm.cmd run lintnpm.cmd run buildChecklist
Summary by CodeRabbit