Skip to content

feat: add select-all canvas shortcut - #536

Open
rgin216 wants to merge 1 commit into
masterfrom
VPS-76/Ctrl-A-Shortcut
Open

feat: add select-all canvas shortcut#536
rgin216 wants to merge 1 commit into
masterfrom
VPS-76/Ctrl-A-Shortcut

Conversation

@rgin216

@rgin216 rgin216 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Issue

No ability to select all components in a scene

Solution

Implemented a ctrl+A function to highlight all components

Summary by CodeRabbit

  • New Features
    • Updated the Select All shortcut:
      • In text mode, it selects all text within the active element.
      • In other modes, it selects all non-audio components in the scene.

@linear

linear Bot commented Sep 2, 2026

Copy link
Copy Markdown

VPS-76

@rgin216
rgin216 requested a review from K1mmyn September 2, 2026 23:13
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: b9fe9a61-1b60-4029-a8e9-4437c207f87e

📥 Commits

Reviewing files that changed from the base of the PR and between c5c7b0f and a818690.

📒 Files selected for processing (1)
  • frontend/src/features/authoring/handlers/keyboard/shortcuts.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The mod+a shortcut now selects all text in text mode and all non-audio components in non-text mode. The shortcut uses getScene() to collect component IDs.

Changes

Select All Shortcut

Layer / File(s) Summary
Mode-specific select-all handling
frontend/src/features/authoring/handlers/keyboard/shortcuts.ts
The shortcut calls handleSelectAllText in text mode. In non-text mode, it selects all non-audio component IDs from getScene().components.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a8186

The change adds Ctrl+A selection for scene components while preserving text-mode behavior. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the issue and solution, but it omits the required Risk and Checklist sections. It also does not provide testing, documentation, acceptance criteria, or CI status. Add the Risk and Checklist sections. State potential risks and provide the status of acceptance criteria, wiki documentation, unit tests, integration tests, and the continuous integration build.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a select-all shortcut for the canvas.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@K1mmyn K1mmyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the bug I found LGTM maybe try to fix it and request me to review it again

@@ -7,12 +7,11 @@ import {
sendToBack,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2026-09-03.at.10.24.00.PM.mov

Duplicating elements and undoing causes the app to crash. This is probably not related to your ticket but this needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants