Skip to content

Upload new slides - #64

Merged
danielrazavi merged 4 commits into
mainfrom
slides_202607
Jul 21, 2026
Merged

Upload new slides#64
danielrazavi merged 4 commits into
mainfrom
slides_202607

Conversation

@kelichiu

Copy link
Copy Markdown
Collaborator

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

New slides for 2026 July git module.

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@github-actions

Copy link
Copy Markdown

Thanks for your contribution! 🎉

Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts.

@danielrazavi
danielrazavi requested a review from moejennie July 20, 2026 16:08

@moejennie moejennie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be multiple slide decks/content versions present in 01_materials, even though the final generated decks should only live in 01_materials/slides/.

The expected structure is:

  • Generated PDF slide decks should be in 01_materials/slides/
  • Markdown slide source files should be in 03_instructional_team/markdown_slides/
  • No slide decks should be directly inside 01_materials/
  • No Markdown slide source files should be inside 01_materials/slides/

It’s also important that slides are generated using the generate_slides.sh script in 03_instructional_team, with the DSI theme applied, so the DSI logo appears consistently at the bottom right of the decks.

@RohanAlexander defer to you and @kelichiu to decide which deck should be kept as the approved version before we clean up the folder structure.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution! 🎉

Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts.

Generate slides with DSI-provided script and theme
@github-actions

Copy link
Copy Markdown

Thanks for your contribution! 🎉

Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts.

@kelichiu

Copy link
Copy Markdown
Collaborator Author

The expected structure is:

  1. ✅ Generated PDF slide decks should be in 01_materials/slides/
  2. ✅ Markdown slide source files should be in 03_instructional_team/markdown_slides/
  3. ❓ No slide decks should be directly inside 01_materials/
  4. ✅ No Markdown slide source files should be inside 01_materials/slides/
  5. ✅ It’s also important that slides are generated using the generate_slides.sh script in 03_instructional_team, with the DSI theme applied, so the DSI logo appears consistently at the bottom right of the decks.

Thanks @moejennie! For 3, there were PDFs and slide source files inside 01_materials/slides/ before my updates. Let me know if I should remove them or place them in a certain directory.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution! 🎉

Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts.

@danielrazavi danielrazavi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelichiu per @RohanAlexander and @moejennie instructions, I have moved those files into 04_this_cohort as additional material. At this moment your changes look good to me. Marking as approved.

@kelichiu
kelichiu requested a review from moejennie July 21, 2026 16:07
@danielrazavi
danielrazavi merged commit 53bd101 into main Jul 21, 2026
1 check passed
@danielrazavi
danielrazavi deleted the slides_202607 branch July 21, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants