Fix autograder PR review permissions - #662
Merged
Merged
Conversation
|
Thanks for your contribution! 🎉 Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts. |
Dmytro-Bonislavskyi
approved these changes
Jul 29, 2026
Dmytro-Bonislavskyi
left a comment
Collaborator
There was a problem hiding this comment.
Well done :) !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The autograder approval flow used to work, but recently it stopped posting approvals or change requests even when the tests passed. We traced the likely cause to GitHub Actions token permissions: newer forked repositories can default to read-only
GITHUB_TOKENpermissions, which lets the autograder run but prevents it from approving or requesting changes on the PR.This PR adds the possible fix by explicitly granting the workflow permission to write pull request reviews, and by making the autograder fail visibly if GitHub rejects the review API call.
Testing
Tested using the same workflow participants follow:
assignmentbranchassignmentinto the fork’smainChanges
pull-requests: writepermission to the autograder workflow.contents: readas the minimal repository content permission.