feat: exempt matching bots from PR description check - #17
Merged
LuWang1983 merged 1 commit intoSep 10, 2026
Merged
Conversation
|
Related Jira Issue: INFR-6089 Improve pr-description-check GitHub Actions workflow. |
LuWang1983
marked this pull request as ready for review
August 27, 2026 17:31
theworkflow
previously approved these changes
Sep 1, 2026
sunnysingh
previously approved these changes
Sep 1, 2026
sunnysingh
reviewed
Sep 1, 2026
sunnysingh
left a comment
Contributor
There was a problem hiding this comment.
Something to note is if we want to publicize this information (i.e. what are the bot names and machine users we have at Alloy).
We can force push a change to this branch that simply checks the prefix alloy- or suffix -ai of the bot names. Or does a partial match, like *release-orchestrator*. This way it's not exactly known what the names of our bots are.
Alternatively we can just go back to exempting all bots but it's something to consider. Sorry this has had a lot of back-and-forth!
theworkflow
previously approved these changes
Sep 2, 2026
LuWang1983
force-pushed
the
task/INFR-6089/exempt-bot-prs-from-description-check
branch
from
September 9, 2026 21:07
e8c78ab to
38811c0
Compare
Skip validation for revert PRs and bots whose login matches alloy or an ai token, so the check can be required without a caller-level job skip.
LuWang1983
dismissed stale reviews from sunnysingh and theworkflow
via
September 9, 2026 21:08
0d417ec
LuWang1983
force-pushed
the
task/INFR-6089/exempt-bot-prs-from-description-check
branch
from
September 9, 2026 21:08
38811c0 to
0d417ec
Compare
theworkflow
approved these changes
Sep 9, 2026
davvblack
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Overview
alloyor anaitoken (hyphen/underscore-delimited), so the check can be made required; bots names are intentionally left out in code due to repo being publicif) so the job reports success instead of staying pendingRelates to INFR-6089.
🤖 Coding AI Authorship
AI implemented bot regex exemption and caller docs; operator directed and reviewed.
🧪 Test Instructions
alloyor anaitoken with empty Overview — check should passif: user.type != 'Bot'Test Results
Not yet run — pending merge.
📝 Authoring Guidelines
As the author, I verify that I have:
🚨 Risks
Required-check behavior depends on callers always invoking this workflow. A caller-level skip would leave bot PRs pending.