Skip to content

feat: exempt matching bots from PR description check - #17

Merged
LuWang1983 merged 1 commit into
masterfrom
task/INFR-6089/exempt-bot-prs-from-description-check
Sep 10, 2026
Merged

feat: exempt matching bots from PR description check#17
LuWang1983 merged 1 commit into
masterfrom
task/INFR-6089/exempt-bot-prs-from-description-check

Conversation

@LuWang1983

@LuWang1983 LuWang1983 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Overview

  • skip description validation for bot authors whose login matches alloy or an ai token (hyphen/underscore-delimited), so the check can be made required; bots names are intentionally left out in code due to repo being public
  • keep exemptions in-script (not a caller if) so the job reports success instead of staying pending
  • other bots must still fill Overview; revert PRs remain exempt

Relates to INFR-6089.

🤖 Coding AI Authorship

  • Human-authored: written almost entirely by hand; maybe some autocomplete, sourced code or scaffolding.
  • Co-authored: agent wrote meaningful portions, significantly edited by me.
  • AI-authored: nearly all agent-authored with minimal human edits if any.
    AI implemented bot regex exemption and caller docs; operator directed and reviewed.

🧪 Test Instructions

  1. Merge this PR
  2. Open a PR authored by a bot whose login contains alloy or an ai token with empty Overview — check should pass
  3. Open a Dependabot (or similar third-party bot) PR with empty Overview — check should fail
  4. Open a human PR with empty/REPLACE ME Overview — check should still fail
  5. Confirm callers do not gate the job with if: user.type != 'Bot'

Test Results

Not yet run — pending merge.

📝 Authoring Guidelines

As the author, I verify that I have:

  • Followed the test instructions and updated the test results.
  • Added/updated unit tests as applicable.
  • Added/updated documentation as applicable.

🚨 Risks

  • Other core setup (please clarify below)

Required-check behavior depends on callers always invoking this workflow. A caller-level skip would leave bot PRs pending.

@Jarvis-Alloy

Copy link
Copy Markdown

@LuWang1983
LuWang1983 marked this pull request as ready for review August 27, 2026 17:31
@LuWang1983
LuWang1983 requested a review from a team August 27, 2026 21:48
@LuWang1983 LuWang1983 self-assigned this Aug 31, 2026
@LuWang1983 LuWang1983 changed the title feat: skip PR description check for bot-authored PRs feat: exempt allowlisted Alloy bots from PR description check Sep 1, 2026
theworkflow
theworkflow previously approved these changes Sep 1, 2026
sunnysingh
sunnysingh previously approved these changes Sep 1, 2026

@sunnysingh sunnysingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to note is if we want to publicize this information (i.e. what are the bot names and machine users we have at Alloy).

We can force push a change to this branch that simply checks the prefix alloy- or suffix -ai of the bot names. Or does a partial match, like *release-orchestrator*. This way it's not exactly known what the names of our bots are.

Alternatively we can just go back to exempting all bots but it's something to consider. Sorry this has had a lot of back-and-forth!

theworkflow
theworkflow previously approved these changes Sep 2, 2026
@LuWang1983 LuWang1983 changed the title feat: exempt allowlisted Alloy bots from PR description check feat: exempt matching bots from PR description check Sep 9, 2026
@LuWang1983
LuWang1983 force-pushed the task/INFR-6089/exempt-bot-prs-from-description-check branch from e8c78ab to 38811c0 Compare September 9, 2026 21:07
Skip validation for revert PRs and bots whose login matches alloy or an
ai token, so the check can be required without a caller-level job skip.
@LuWang1983
LuWang1983 dismissed stale reviews from sunnysingh and theworkflow via 0d417ec September 9, 2026 21:08
@LuWang1983
LuWang1983 force-pushed the task/INFR-6089/exempt-bot-prs-from-description-check branch from 38811c0 to 0d417ec Compare September 9, 2026 21:08
@LuWang1983
LuWang1983 merged commit 4af6d2b into master Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants