Add Namco WSG family support - #151
Open
cam900 wants to merge 3 commits into
Open
Conversation
This PR add support of: - Namco WSG (Standard 3 voice discrete WSG, some hardware has compatible sound generator with RAM) - Namco Pole Position WSG (8 voice quadraphonic WSG used for pole position series) - Namco C15 (aka 15XX, 8 voice mono WSG) - Namco C30 (aka CUS30, 8 voice mono/stereo WSG with noise generator and RAM) All of these core is based on MAME namco.cpp core. Header size is increased for allow more chip support (its size is placeholder)
Owner
|
small note: The reason I haven't merged this so far is, that I'm very split about whether or not I want WSG support in the VGM format due to the very small number of games that use each variant of the chip. I haven't ruled it out, but I also don't feel like adding even more chips right now. |
Contributor
|
One compromise could be to add the chips to libvgm's emu library without adding them to the VGM format. |
Owner
|
Oh, that's a good point! |
|
At that point I'd expect the PR's author to state their plans regarding the added emulation (which at this point is meant for in .vgm). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add support of:
All of these cores are based on MAME namco.cpp core.
Header size is increased for allow more chip support (its size is placeholder)
Related MAME branch: https://github.com/cam900/mame/tree/mao_vgm