Skip to content

[LEGIT] Fix - js/polynomial-redos #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liorn-test-app wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[LEGIT] Fix - js/polynomial-redos #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/routes/profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@ function ProfileHandler (db) {
// The Fix: Instead of using greedy quantifiers the same regex will work if we omit the second quantifier +
// const regexPattern = /([0-9]+)\#/;
const regexPattern = /[0-9]+\#/;
// Validate bankRouting input before regex to prevent DoS via excessive input length
if (typeof bankRouting !== 'string' || bankRouting.length > 50) {
return res.render("profile", {
updateError: "Bank Routing number format is invalid",
firstName,
lastName,
ssn,
dob,
address,
bankAcc,
bankRouting: ''
});
}
// Allow only numbers with a suffix of the letter #, for example: 'XXXXXX#'
const testComplyWithRequirements = regexPattern.test(bankRouting);
// if the regex test fails we do not allow saving
Expand Down
Loading