fix: preserve SDK release notification workflow#6
Open
dhruva-vapi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear ticket
https://linear.app/vapi/issue/PRISM-1195/sdk-releases-preserve-slack-notifications-across-fern-generation
Value
Vapi employees will keep receiving SDK release PR review notifications after Fern regenerates this SDK. Fern now treats the hand-written Slack workflow as repository-owned instead of deleting it.
We found the workflow existed in every server SDK repository but was missing from each
.fernignore.Evidence of value
main..fernignorenow contains the exact workflow path once..fernignorechanged and the diff passes whitespace validation.API Changes (including webhooks + events)
Is this changing the public API?
If yes, is it backward-compatible?
Non backward-compatible changes might break customers' agents. Please proceed with care and notify the team.
Testing plan
Merge this PR, then confirm the next Fern-generated SDK PR does not delete
.github/workflows/sdk-release-pr-notification.yml. A missing workflow or missing release-review message in#production-release-observabilityindicates a regression.