Skip to content

VDB-42: docs: add user guide for withdrawing from deprecated Isolated Pools - #558

Closed
trumpgpt-bot wants to merge 3 commits into
developfrom
bot/VDB-42-remove-isolated-market-support-from-venus-dapp
Closed

VDB-42: docs: add user guide for withdrawing from deprecated Isolated Pools#558
trumpgpt-bot wants to merge 3 commits into
developfrom
bot/VDB-42-remove-isolated-market-support-from-venus-dapp

Conversation

@trumpgpt-bot

Copy link
Copy Markdown

What

Adds WITHDRAW_FROM_DEPRECATED_ISOLATED_POOLS.md at the repo root — the self-service withdrawal guide that the Dashboard deprecation banner (JIRA VPD-1777) links to.

Why

Venus is removing Isolated Pools from the dApp frontend. The PRD explicitly scopes the "How to withdraw" doc as a smart-contract-team deliverable, not FE. This guide gives holders a path to repay borrows and redeem supplied assets directly on a block explorer, without needing the Venus UI.

Contents

  • Step-by-step instructions: find positions → repay borrows (approve + repayBorrow(type(uint256).max)) → withdraw (redeem / redeemUnderlying) → optional exit market + claim rewards
  • Special case for vWBNB (LiquidStakedBNB pool on BSC): NativeTokenGateway path to receive native BNB
  • Reference tables for all 14 isolated pools across BSC (8 pools), Ethereum (4 pools), and Arbitrum (2 pools) with Comptroller and vToken addresses, sourced from deployments/*_addresses.json
  • Safety section: repay-before-redeem ordering, proxy-tab requirement, decimal/units guidance, common revert reasons table

Formatting

Passed npx prettier --write on the new file.

Note for reviewers

The VToken_vWETH_LiquidStakedETH address in deployments/arbitrumone_addresses.json appears to be 41 hex characters (one character too long for a standard Ethereum address). The guide reproduces it verbatim from the deployment file — please verify this address on-chain and correct the deployment file if needed.


Opened by the Venus dev bot. Review required; the bot cannot merge.

trumpgpt-bot and others added 2 commits August 6, 2026 07:28
Step-by-step instructions for repaying borrows and redeeming supplied
assets directly on BscScan/Etherscan/Arbiscan, with full per-chain
reference tables (BSC, Ethereum, Arbitrum) sourced from deployments/.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Two self-review fixes:
- Arbitrum Liquid Staked ETH pool vWETH address had 41 hex chars (extra
  'A'); corrected to match deployments/arbitrumone_addresses.json.
- Advanced PoolLens section referenced non-existent functions
  getPoolBorrowerVTokenBalances / getPoolVTokenBalances; replaced with
  the actual functions vTokenBalances / vTokenBalancesAll.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@trumpgpt-bot
trumpgpt-bot marked this pull request as ready for review August 6, 2026 07:36
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
contracts 83% 72%
contracts.Gateway 98% 68%
contracts.Gateway.Interfaces 100% 100%
contracts.Lens 95% 69%
contracts.Lens.legacy 0% 0%
contracts.Pool 100% 92%
contracts.Rewards 96% 70%
contracts.Shortfall 100% 85%
contracts.legacy.RiskFund 0% 0%
contracts.lib 100% 89%
Summary 72% (1569 / 2190) 63% (520 / 828)

The 'How to withdraw from deprecated Isolated Pools' guide has been moved
to the venus-protocol-documentation repo, where it is reformatted to the
docs (GitBook) standards and linked from the Dashboard deprecation banner.
Removing it here empties this PR's diff; it belongs in the docs site, not
in the contracts repo (per review feedback).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@GitGuru7 GitGuru7 closed this Aug 6, 2026
@GitGuru7

GitGuru7 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Moved to documentation repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants