feat/add jikan api - #109
Open
IbbyLabs wants to merge 5 commits into
Open
Conversation
IbbyLabs
commented
Jun 24, 2026
IbbyLabs
commented
Contributor
- feat(jikan-api): add the Jikan API to template
- fix(jikan-api): fix missing fs require, add secrets dir creation, and add Typesense healthcheck
IbbyLabs
marked this pull request as draft
June 24, 2026 15:49
Contributor
Author
|
Going to test it first.. |
IbbyLabs
force-pushed
the
feat/add-jikan-api
branch
from
June 24, 2026 22:10
8b1aa18 to
245b13f
Compare
IbbyLabs
marked this pull request as ready for review
June 24, 2026 22:31
This commit adds the Jikan API to the project template, including necessary configuration files and instructions for setup. - Remove duplicate DB_ADMIN__FILE from .env.compose (pointed to wrong secret; admin creds not mounted in jikan_rest) - Fix YAML flow-sequence bracket spacing throughout compose.yaml - Fix mongo-init volume source: ./mongo-init.js → ./mongo-init.sh - Tighten secret file permissions in instructions: chmod 644 → chmod 600 - Correct RoadRunner supervisor key in instructions: supervisor.ttl → supervisor.exec_ttl - Add .trim() to fs.readFileSync calls in mongo-init.sh to strip trailing newlines
… add Typesense healthcheck
- Add const fs = require('fs') to mongo-init.sh (fs was used but never imported)
- Add mkdir -p secrets to instructions.md setup snippet before redirect commands
- Add healthcheck to jikan_typesense service (wget on port 8108/health)
- Upgrade jikan_rest depends_on jikan_typesense from service_started to service_healthy
- Add trailing newline to instructions.md
…wget
The typesense/typesense:0.24.1 image ships no wget/curl/nc, so the wget-based healthcheck always exited 127 and the container never became healthy, which blocked jikan_rest from starting (depends_on: service_healthy). Use bash (present in the image) with /dev/tcp to GET /health and confirm the server reports {"ok":true}.
…t/secrets The six credential files created per instructions.md (db/redis/typesense usernames, passwords, API key) were untracked and at risk of being committed. Ignore the directory contents while keeping the .gitkeep placeholder tracked.
IbbyLabs
force-pushed
the
feat/add-jikan-api
branch
from
August 20, 2026 18:58
645a707 to
2c77051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.