GUI: reduce macOS repaint and Dock preview overhead#745
Open
moreaki wants to merge 2 commits into
Open
Conversation
Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Signed-off-by: Roberto Nibali <rnibali@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce macOS Qt frontend repaint overhead for VM display updates.
The change:
QImagesource rectangles instead of materializing a temporaryQPixmapfor each paint rectangle,Scope
This is a macOS frontend performance improvement, not part of the minimal functional Retina/HiDPI enablement tracked by #742.
The intended validation baseline for this PR is the functional/stability stack needed to run a Windows 11 ARM guest reliably on macOS/Arm with VMSVGA 3D and high-resolution modes enabled. It should be measured separately from #744 so the frontend repaint contribution is attributable.
Why
The macOS frontend was doing avoidable work for high-frequency guest display updates, which was especially visible with high-resolution Retina guest framebuffers.
Benchmark source
The reproducible benchmark suite used for final throughput validation is:
https://github.com/moreaki/dxmtbench
The suite runs browser-based WebGL/D3D-backed workloads inside the Windows guest, captures visual-output evidence, records throughput metrics, and exports machine-readable results. I will update this PR with isolated before/after dxmtbench results before treating it as a final performance submission.
Validation
origin/main.git diff --checkpasses.Refs #742.