Skip to content

Additions/WDDM: add Retina-scaled video modes#749

Open
moreaki wants to merge 1 commit into
VirtualBox:mainfrom
moreaki:agent/wddm-retina-scaled-modes
Open

Additions/WDDM: add Retina-scaled video modes#749
moreaki wants to merge 1 commit into
VirtualBox:mainfrom
moreaki:agent/wddm-retina-scaled-modes

Conversation

@moreaki

@moreaki moreaki commented Jul 8, 2026

Copy link
Copy Markdown

Summary

Add aspect-preserving intermediate modes to the Windows Guest Additions WDDM mode list.

For a 5760x3240 Retina target, the generated modes are:

  • 5120x2880
  • 3840x2160
  • 3200x1800
  • 2880x1620
  • 2560x1440
  • 1920x1080

Why

The previous built-in WDDM list exposed the native Retina target mode and then mostly legacy 4:3/5:4 modes such as 1920x1440, 1600x1200, and 1280x1024. That made Windows Display Settings awkward for high-DPI hosts because useful aspect-correct intermediate Retina modes were missing.

The new code derives scaled modes from the current/preferred target size and keeps the existing VRAM/frontend mode checks.

Validation

  • Applied independently to origin/main.
  • git diff --check passes.
  • VBoxWddm build was attempted, but the local macOS ARM64 tree lacks a configured Windows SDK/WDK (PATH_SDK_WINSDK10), so the build stopped before compiling the driver.
  • The mode-list behavior was validated through the existing driver's custom-mode registry path. Windows Display Settings exposed the same intermediate modes listed above.

Refs #742.

Signed-off-by: Roberto Nibali <rnibali@gmail.com>
@oracle-contributor-agreement

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jul 8, 2026
@moreaki moreaki marked this pull request as ready for review July 8, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant