Additions/WDDM: add Retina-scaled video modes#749
Open
moreaki wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add aspect-preserving intermediate modes to the Windows Guest Additions WDDM mode list.
For a
5760x3240Retina target, the generated modes are:5120x28803840x21603200x18002880x16202560x14401920x1080Why
The previous built-in WDDM list exposed the native Retina target mode and then mostly legacy 4:3/5:4 modes such as
1920x1440,1600x1200, and1280x1024. That made Windows Display Settings awkward for high-DPI hosts because useful aspect-correct intermediate Retina modes were missing.The new code derives scaled modes from the current/preferred target size and keeps the existing VRAM/frontend mode checks.
Validation
origin/main.git diff --checkpasses.VBoxWddmbuild was attempted, but the local macOS ARM64 tree lacks a configured Windows SDK/WDK (PATH_SDK_WINSDK10), so the build stopped before compiling the driver.Refs #742.