configure: quote generated shell environment values#752
Open
moreaki wants to merge 1 commit into
Open
Conversation
Quote non-Windows env.sh values when writing generated build environment files. This keeps source ./env.sh working when inherited environment values such as PATH contain spaces. Windows env.bat output is left unchanged. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quote non-Windows generated
env.shvalues before writingexport KEY=valuelines.This keeps
source ./env.shworking when inherited environment values contain spaces, for example aPATHentry under a macOS.appbundle.Windows
env.batoutput is left unchanged.Why
Without quoting, a generated line such as:
export PATH=/usr/bin:/Applications/Little Snitch.app/Contents/Components:/binis parsed by the shell as a split assignment and an invalid additional export argument. The generated POSIX shell environment file should emit a quoted value instead.
Validation
python3 -m py_compile configure.pyenv.shvalue with/Applications/Little Snitch.app/...inPATHand verified thatsourcerestores the exact original value.git diff --checkCloses #750.