DXMT: keep indexed draw base vertex signed#758
Open
moreaki wants to merge 1 commit into
Open
Conversation
D3D11 indexed draw calls take BaseVertexLocation as a signed INT, and Metal's baseVertex parameter is signed as well. Keep the DXMT indirect argument and winemetal command fields signed so negative base-vertex offsets are not reinterpreted as large unsigned values. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep indexed draw base vertex values signed across the DXMT/winemetal command boundary.
BaseVertexLocationis signed in D3D11, and Metal's indexed drawbaseVertexargument is signed as well. This patch changes the stored command fields fromuint32_ttoint32_tso negative base vertex values are not reinterpreted as very large unsigned offsets.Validation
git diff --checkkmk VBoxDxMton macOS/Arm using LLVM 15.0.7.Closes #754.
Signed-off-by: Roberto Nibali rnibali@gmail.com