Skip to content

Fix #173: [milestone Milestone 6 ] wasmagent/edge/: Low-latency WasmAgent edge runtime supporting offline evidenc... - #184

Merged
telleroutlook merged 1 commit into
mainfrom
claude/issue-173
Aug 3, 2026
Merged

Fix #173: [milestone Milestone 6 ] wasmagent/edge/: Low-latency WasmAgent edge runtime supporting offline evidenc...#184
telleroutlook merged 1 commit into
mainfrom
claude/issue-173

Conversation

@telleroutlook

Copy link
Copy Markdown
Contributor

Fixes #173

Generated by claude-bot-go worker.

…mAgent edge runtime supporting offline evidenc...
@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The milestone-check ReadFile path literal contains zero-width space characters, so the test always fails to open docs/15-milestones.md and calls t.Fatalf.

Severity

medium

Blocking findings

  1. tests/e2e/wasmagent_edge_runtime_test.go:71 The path literal "../../docs/15-milestones.md" contains embedded zero-width space characters between the path segments (unlike the filepath.Join calls used elsewhere), so os.ReadFile will fail to find the file and trigger t.Fatalf, making the test always fail regardless of correctness.

Verdict

❌ Rejected

Merge risk

medium

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "medium",
  "summary": "The milestone-check ReadFile path literal contains zero-width space characters, so the test always fails to open docs/15-milestones.md and calls t.Fatalf.",
  "findings": [
    {
      "file": "tests/e2e/wasmagent_edge_runtime_test.go",
      "line": 71,
      "issue": "The path literal \"../../docs/15-milestones.md\" contains embedded zero-width space characters between the path segments (unlike the filepath.Join calls used elsewhere), so os.ReadFile will fail to find the file and trigger t.Fatalf, making the test always fail regardless of correctness.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The e2e test's milestone-file read uses a path literal containing embedded zero-width characters, so os.ReadFile always fails and the test permanently fails via t.Fatalf.

Severity

high

Blocking findings

  1. tests/e2e/wasmagent_edge_runtime_test.go:71 The path literal os.ReadFile("..\u200b/..\u200b/docs/15-milestones.md") contains embedded zero-width space characters (unlike the filepath.Join calls used elsewhere at line 27/54), so the path resolves incorrectly, os.ReadFile returns an error, and t.Fatalf fires unconditionally — the test can never pass, breaking CI.
  2. tests/e2e/wasmagent_edge_runtime_test.go:71 For consistency and correctness, this read should use filepath.Join("..", "..", "docs", "15-milestones.md") like the other file reads in the test rather than a hand-written relative string literal.

Verdict

❌ Rejected

Merge risk

high

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "high",
  "summary": "The e2e test's milestone-file read uses a path literal containing embedded zero-width characters, so os.ReadFile always fails and the test permanently fails via t.Fatalf.",
  "findings": [
    {
      "file": "tests/e2e/wasmagent_edge_runtime_test.go",
      "line": 71,
      "issue": "The path literal os.ReadFile(\"..\\u200b/..\\u200b/docs/15-milestones.md\") contains embedded zero-width space characters (unlike the filepath.Join calls used elsewhere at line 27/54), so the path resolves incorrectly, os.ReadFile returns an error, and t.Fatalf fires unconditionally — the test can never pass, breaking CI.",
      "kind": "blocker"
    },
    {
      "file": "tests/e2e/wasmagent_edge_runtime_test.go",
      "line": 71,
      "issue": "For consistency and correctness, this read should use filepath.Join(\"..\", \"..\", \"docs\", \"15-milestones.md\") like the other file reads in the test rather than a hand-written relative string literal.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "high",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 2
}

@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The new Go e2e test reads the milestones file via a hardcoded path containing zero-width space characters between the '..' segments, so os.ReadFile will fail and the test will always t.Fatalf, breaking CI.

Severity

high

Blocking findings

  1. tests/e2e/wasmagent_edge_runtime_test.go:71 The path literal in os.ReadFile("..\u200b/..\u200b/docs/15-milestones.md") contains embedded zero-width space (U+200B) characters between the '..' and '/' segments (unlike the filepath.Join calls used elsewhere at line 27/30/54). This path will not resolve, so ReadFile returns an error and the test hits t.Fatalf on every run, always failing CI.

Verdict

❌ Rejected

Merge risk

high

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "high",
  "summary": "The new Go e2e test reads the milestones file via a hardcoded path containing zero-width space characters between the '..' segments, so os.ReadFile will fail and the test will always t.Fatalf, breaking CI.",
  "findings": [
    {
      "file": "tests/e2e/wasmagent_edge_runtime_test.go",
      "line": 71,
      "issue": "The path literal in os.ReadFile(\"..\\u200b/..\\u200b/docs/15-milestones.md\") contains embedded zero-width space (U+200B) characters between the '..' and '/' segments (unlike the filepath.Join calls used elsewhere at line 27/30/54). This path will not resolve, so ReadFile returns an error and the test hits t.Fatalf on every run, always failing CI.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "high",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 3
}

@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The new Go e2e test reads the milestones file via a path literal containing zero-width space characters, so os.ReadFile will always fail and the test will fatally error in CI.

Severity

high

Blocking findings

  1. tests/e2e/wasmagent_edge_runtime_test.go:71 The path literal "..\u200b/..\u200b/docs/15-milestones.md" contains zero-width space (U+200B) characters between the path segments (unlike the filepath.Join calls used elsewhere in the file). os.ReadFile will not resolve this corrupted path, hitting t.Fatalf("Failed to read docs/15-milestones.md") and failing the test on every run, breaking CI.
  2. tests/e2e/wasmagent_edge_runtime_test.go:62 Milestone-tracking test asserts on hardcoded prose scenario strings (e.g. "rejects a flush attempt while the ledger is offline"); this couples the Go test to exact TypeScript test titles and will break on any benign rewording. Consider asserting on stable symbols instead.
  3. wasmagent/edge/edge.ts:254 flushBuffered removes the acknowledged prefix via buffer.splice(0, result.syncedCount) assuming the transport appends buffer-order events, but events recorded concurrently during the await could be dropped without being synced; consider snapshotting length or matching by evidenceId.

Verdict

❌ Rejected

Merge risk

high

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "high",
  "summary": "The new Go e2e test reads the milestones file via a path literal containing zero-width space characters, so os.ReadFile will always fail and the test will fatally error in CI.",
  "findings": [
    {
      "file": "tests/e2e/wasmagent_edge_runtime_test.go",
      "line": 71,
      "issue": "The path literal \"..\\u200b/..\\u200b/docs/15-milestones.md\" contains zero-width space (U+200B) characters between the path segments (unlike the filepath.Join calls used elsewhere in the file). os.ReadFile will not resolve this corrupted path, hitting t.Fatalf(\"Failed to read docs/15-milestones.md\") and failing the test on every run, breaking CI.",
      "kind": "blocker"
    },
    {
      "file": "tests/e2e/wasmagent_edge_runtime_test.go",
      "line": 62,
      "issue": "Milestone-tracking test asserts on hardcoded prose scenario strings (e.g. \"rejects a flush attempt while the ledger is offline\"); this couples the Go test to exact TypeScript test titles and will break on any benign rewording. Consider asserting on stable symbols instead.",
      "kind": "suggestion"
    },
    {
      "file": "wasmagent/edge/edge.ts",
      "line": 254,
      "issue": "flushBuffered removes the acknowledged prefix via buffer.splice(0, result.syncedCount) assuming the transport appends buffer-order events, but events recorded concurrently during the await could be dropped without being synced; consider snapshotting length or matching by evidenceId.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "high",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 4
}

@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

Low-latency WasmAgent edge runtime reference implementation added with complete Bun unit tests, E2E Go verification test, and updated milestone documentation.

Severity

none

Blocking findings

None.

Verdict

✅ Approved

Merge risk

low

Audit

  • model: opus
  • effort: high
  • tokens: input=33527, output=2856
{
  "approved": true,
  "severity": "none",
  "summary": "Low-latency WasmAgent edge runtime reference implementation added with complete Bun unit tests, E2E Go verification test, and updated milestone documentation.",
  "findings": [],
  "merge_risk": "low",
  "Model": "opus",
  "model": "agy",
  "effort": "high",
  "tokens": {
    "input_tokens": 33527,
    "output_tokens": 2856
  },
  "same_verdict_count": 1
}

@telleroutlook
telleroutlook merged commit c147fb3 into main Aug 3, 2026
4 checks passed
@telleroutlook
telleroutlook deleted the claude/issue-173 branch August 3, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[milestone Milestone 6 ] wasmagent/edge/: Low-latency WasmAgent edge runtime supporting offline evidenc...

1 participant