Fix #100: [milestone Milestone 2 ] In open-agent-audit, add an adapter mapping `schemas/v0.1/canonical-event.sche... - #194
Open
telleroutlook wants to merge 6 commits into
Open
Conversation
added 4 commits
August 1, 2026 20:54
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
Contributor
Author
SummaryThe adapter rejects schema-valid canonical events that omit run_id, despite CanonicalEvent not requiring that field. Severitymedium Blocking findings
Verdict❌ Rejected Merge riskmedium Audit
{
"approved": false,
"severity": "medium",
"summary": "The adapter rejects schema-valid canonical events that omit run_id, despite CanonicalEvent not requiring that field.",
"findings": [
{
"file": "index.js",
"line": 60,
"issue": "The adapter unconditionally requires a non-empty run_id, but the canonical-event/v0.1 schema only requires schema_version, event_id, event_type, and timestamp_ms; valid canonical events without run_id therefore cannot be mapped through the declared API.",
"kind": "blocker"
}
],
"merge_risk": "medium",
"Model": "opus",
"model": "codex",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 1
} |
Contributor
Author
SummaryThe adapter rejects valid canonical events that omit run_id even though the canonical schema does not require that field. Severityhigh Blocking findings
Verdict❌ Rejected Merge riskhigh Audit
{
"approved": false,
"severity": "high",
"summary": "The adapter rejects valid canonical events that omit run_id even though the canonical schema does not require that field.",
"findings": [
{
"file": "index.js",
"line": 67,
"issue": "canonicalEventToAEPRecord unconditionally requires a non-empty run_id, but canonical-event.schema.json only requires schema_version, event_id, event_type, and timestamp_ms; valid minimal canonical events therefore cannot be adapted.",
"kind": "blocker"
}
],
"merge_risk": "high",
"Model": "opus",
"model": "codex",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 2
} |
added 2 commits
August 2, 2026 00:12
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
Contributor
Author
SummaryThe fallback run ID can incorrectly merge unrelated events or split one run into separate runs. Severityhigh Blocking findings
Verdict❌ Rejected Merge riskhigh Audit
{
"approved": false,
"severity": "high",
"summary": "The fallback run ID can incorrectly merge unrelated events or split one run into separate runs.",
"findings": [
{
"file": "index.js",
"line": 65,
"issue": "When run_id is absent, deriving it solely from event_id is unsafe because canonical-event only guarantees event_id uniqueness within a trace; events from different traces can collide, while events from one run become separate runs.",
"kind": "blocker"
}
],
"merge_risk": "high",
"Model": "opus",
"model": "codex",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 3
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Generated by claude-bot-go worker.