Skip to content

Fix #100: [milestone Milestone 2 ] In open-agent-audit, add an adapter mapping `schemas/v0.1/canonical-event.sche... - #194

Open
telleroutlook wants to merge 6 commits into
mainfrom
claude/issue-100-race-23727
Open

Fix #100: [milestone Milestone 2 ] In open-agent-audit, add an adapter mapping `schemas/v0.1/canonical-event.sche...#194
telleroutlook wants to merge 6 commits into
mainfrom
claude/issue-100-race-23727

Conversation

@telleroutlook

Copy link
Copy Markdown
Contributor

Fixes #100

Generated by claude-bot-go worker.

claude-bot-go added 4 commits August 1, 2026 20:54
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The adapter rejects schema-valid canonical events that omit run_id, despite CanonicalEvent not requiring that field.

Severity

medium

Blocking findings

  1. index.js:60 The adapter unconditionally requires a non-empty run_id, but the canonical-event/v0.1 schema only requires schema_version, event_id, event_type, and timestamp_ms; valid canonical events without run_id therefore cannot be mapped through the declared API.

Verdict

❌ Rejected

Merge risk

medium

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "medium",
  "summary": "The adapter rejects schema-valid canonical events that omit run_id, despite CanonicalEvent not requiring that field.",
  "findings": [
    {
      "file": "index.js",
      "line": 60,
      "issue": "The adapter unconditionally requires a non-empty run_id, but the canonical-event/v0.1 schema only requires schema_version, event_id, event_type, and timestamp_ms; valid canonical events without run_id therefore cannot be mapped through the declared API.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The adapter rejects valid canonical events that omit run_id even though the canonical schema does not require that field.

Severity

high

Blocking findings

  1. index.js:67 canonicalEventToAEPRecord unconditionally requires a non-empty run_id, but canonical-event.schema.json only requires schema_version, event_id, event_type, and timestamp_ms; valid minimal canonical events therefore cannot be adapted.

Verdict

❌ Rejected

Merge risk

high

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "high",
  "summary": "The adapter rejects valid canonical events that omit run_id even though the canonical schema does not require that field.",
  "findings": [
    {
      "file": "index.js",
      "line": 67,
      "issue": "canonicalEventToAEPRecord unconditionally requires a non-empty run_id, but canonical-event.schema.json only requires schema_version, event_id, event_type, and timestamp_ms; valid minimal canonical events therefore cannot be adapted.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "high",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 2
}

claude-bot-go added 2 commits August 2, 2026 00:12
…ter mapping `schemas/v0.1/canonical-event.sche...
…ter mapping `schemas/v0.1/canonical-event.sche...
@telleroutlook

Copy link
Copy Markdown
Contributor Author

Summary

The fallback run ID can incorrectly merge unrelated events or split one run into separate runs.

Severity

high

Blocking findings

  1. index.js:65 When run_id is absent, deriving it solely from event_id is unsafe because canonical-event only guarantees event_id uniqueness within a trace; events from different traces can collide, while events from one run become separate runs.

Verdict

❌ Rejected

Merge risk

high

Audit

  • model: opus
  • effort: high
  • tokens: input=0, output=0
{
  "approved": false,
  "severity": "high",
  "summary": "The fallback run ID can incorrectly merge unrelated events or split one run into separate runs.",
  "findings": [
    {
      "file": "index.js",
      "line": 65,
      "issue": "When run_id is absent, deriving it solely from event_id is unsafe because canonical-event only guarantees event_id uniqueness within a trace; events from different traces can collide, while events from one run become separate runs.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "high",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 3
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[milestone Milestone 2 ] In open-agent-audit, add an adapter mapping `schemas/v0.1/canonical-event.sche...

1 participant