Fix #100: [milestone Milestone 2 ] In open-agent-audit, add an adapter mapping `schemas/v0.1/canonical-event.sche...

[telleroutlook]

Fixes #100

Generated by claude-bot-go worker.

[telleroutlook]

Summary

The PR weakens CI coverage by redefining a test function and shadowing the earlier parametrized test suite.

Severity

high

Blocking findings

1. tests/test_canonical_event_contract.py:228 The test_non_action_canonical_events_map_to_aep_fields function is defined a second time, so pytest collects only the later definition and silently skips the earlier parametrized cases.

Verdict

❌ Rejected

Merge risk

high

Audit

• model: opus
• effort: high
• tokens: input=0, output=0

{
  "approved": false,
  "severity": "high",
  "summary": "The PR weakens CI coverage by redefining a test function and shadowing the earlier parametrized test suite.",
  "findings": [
    {
      "file": "tests/test_canonical_event_contract.py",
      "line": 228,
      "issue": "The test_non_action_canonical_events_map_to_aep_fields function is defined a second time, so pytest collects only the later definition and silently skips the earlier parametrized cases.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "high",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

[telleroutlook]

Summary

The adapter can emit AEP records that fail the authoritative schema for otherwise accepted inputs.

Severity

medium

Blocking findings

1. index.js:90 Input and output references are copied without validating that uri is a string; a malformed canonical event with a matching relation can produce an AEP reference missing its required valid uri, while the adapter performs no error or filtering.

Verdict

❌ Rejected

Merge risk

medium

Audit

• model: opus
• effort: high
• tokens: input=0, output=0

{
  "approved": false,
  "severity": "medium",
  "summary": "The adapter can emit AEP records that fail the authoritative schema for otherwise accepted inputs.",
  "findings": [
    {
      "file": "index.js",
      "line": 90,
      "issue": "Input and output references are copied without validating that uri is a string; a malformed canonical event with a matching relation can produce an AEP reference missing its required valid uri, while the adapter performs no error or filtering.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 2
}

[telleroutlook]

Summary

The adapter drops evidence references for every non-action canonical event.

Severity

medium

Blocking findings

1. index.js:124 Evidence references are mapped only inside the action-event branch, so evidence refs on decision, observation, error, or lifecycle events are not routed to any AEP field despite the adapter contract promising evidence-reference routing.

Verdict

❌ Rejected

Merge risk

medium

Audit

• model: opus
• effort: high
• tokens: input=0, output=0

{
  "approved": false,
  "severity": "medium",
  "summary": "The adapter drops evidence references for every non-action canonical event.",
  "findings": [
    {
      "file": "index.js",
      "line": 124,
      "issue": "Evidence references are mapped only inside the action-event branch, so evidence refs on decision, observation, error, or lifecycle events are not routed to any AEP field despite the adapter contract promising evidence-reference routing.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 3
}

[telleroutlook]

Summary

No merge-blocking correctness, security, compatibility, or test-integrity issues are evident in the diff.

Severity

none

Blocking findings

None.

Verdict

✅ Approved

Merge risk

low

Audit

• model: opus
• effort: high
• tokens: input=0, output=0

{
  "approved": true,
  "severity": "none",
  "summary": "No merge-blocking correctness, security, compatibility, or test-integrity issues are evident in the diff.",
  "findings": [],
  "merge_risk": "low",
  "Model": "opus",
  "model": "codex",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

[telleroutlook]

Closing: GitHub CI failed. Bot will reimplement with CI failure context.