Serialize configuration and log updates with bounded file locks - #2
Merged
Conversation
Water-Run
marked this pull request as ready for review
September 7, 2026 04:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent
get setoperations could overwrite updates to different settings, while log append/trim/clean operations could lose or interleave entries. This change locks the full configuration read-modify-write sequence and each log mutation. Bounded retention scans historical entries incrementally and atomically replaces the retained tail.Key writes, full configuration saves, and reset share the settings lock; Windows readers cooperate with replacement. OS ownership is released on exit, lock contention has a five-second wait budget, and invalid setters release their lock. Persistent empty sidecar files avoid unlink/recreate races. Older binaries and external editors do not participate; two-file reset is not a crash-atomic database transaction.
Adds seven small worker regressions and shared-desktop resource constraints in AGENTS.md. The existing POSIX executor test now checks actual child-process interval overlap and stable result order, replacing a fixed 750 ms cutoff that failed on macOS at 773 ms.
Validation on final commit
29308e8b55d570248fbe8e8a1e175a807b7f6554:All native gates passed, including HTTPS and installer checks. Independent Windows CI also passed. Local focused checks passed: 7 state-lock regressions, 2 existing persistence tests, and the executor interval regression; Windows/macOS target checks passed. Local compilation used one low-priority compiler with
--parallelBuild:1and a 2 GiB per-process address-space cap.