fix hermeticity - #3104
Open
hustlerone wants to merge 1 commit into
Open
Conversation
ammen99
reviewed
Aug 22, 2026
|
|
||
| // TODO: do we need some kind of dependency here? | ||
| #include <drm_fourcc.h> | ||
| #include <libdrm/drm_fourcc.h> |
Member
There was a problem hiding this comment.
This seems wrong, on my system, pkg-config --cflags libdrm gives -I/usr/include/libdrm where drm_fourcc.h is located. wlroots also includes the header with just drm_fourcc.h so I think that after adding the drm dep, you shouldn't need this.
There was a problem hiding this comment.
I think adding drm to the meson.build is the only change that should be necessary.
Even in nixpkgs pkg-config correctly returns .../libdrm as an include dir:
$ pkg-config --cflags libdrm
-I/nix/store/jl06f30bsw7ya4qvlpawjqx23x52hm62-libdrm-2.4.133-dev/include -I/nix/store/jl06f30bsw7ya4qvlpawjqx23x52hm62-libdrm-2.4.133-dev/include/libdrm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can't build in nix without patching this in