CABI: refactor/simplify stream/future logic; fix delivery of DROPPED - #719
Open
lukewagner wants to merge 1 commit into
Open
CABI: refactor/simplify stream/future logic; fix delivery of DROPPED#719lukewagner wants to merge 1 commit into
DROPPED#719lukewagner wants to merge 1 commit into
Conversation
lukewagner
force-pushed
the
more-simplify
branch
from
September 13, 2026 18:14
205ac74 to
35e9769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out the first commit of #717, since it's pretty nice on its own and can be merged earlier since it's just behavior-preserving refactoring, except for fixing a spec bug (where
DROPPEDwasn't being delivered promptly even though the other side had dropped) that now matches wasmtime.The PR is able to remove 125 lines (!) from
definitions.pyby merging future+stream and read+write definitions that were formerly separate. The key simplification was removing the intermediatesharedobject that both the readable/writable ends point to. Previously, thissharedobject seemed necessary to serve as the host/guest abstract interface, but as this PR shows, a better alternative is to instead say that the host owns and uses a readable/writable end directly (as if it was a component with its ownhandlestable), and thus the two ends can just point to each other directly with no intermediate object.