Ref tags with slash - #386
Merged
AngledLuffa merged 2 commits intoAug 2, 2026
Merged
Conversation
…n't close the whole tag (it was missing <ref> tags in SKR, for example)
… the closing > in quotes should not close the whole tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a ref tag has a slash in quoted attributes - or even a
>apparent closing tag - this should not actually terminate the processing of the tag. For example, there are legitimate tags which look like<ref name="brecorder/12feb2012">throughout various datasets, this example coming from SKR. These tags should be processed the same as any other ref tag.
With the help of Claude, this change extends the tag matching regex to allow for
/or>in quoted attributes.