Fix: Undefined tab panel TypeError in CreateWiki form - #6
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a
TypeError: undefined is not an object (evaluating 'panel.$element')that occurs inmodules/ext.createwiki.oouiform.ooui.js.The root cause was identified as
enhancePanel()being called with anundefinedpanel object. This happened becauseswitchCreateWikiTab()was invoked with anundefinedtab name (derived from$("[id*=mw-section-]").attr("id")when no such element existed on pages likeSpecial:RequestWikiQueue), causingtabs.getCurrentTabPanel()to returnundefined.The fix implements two safeguards:
enhancePanel()function to prevent dereferencing$elementon anundefinedpanel.hashchangeevent handler, specifically for thehash === ''branch, a check has been added to ensure that$("[id*=mw-section-]")actually finds an element before attempting to retrieve itsidand callswitchCreateWikiTab.Fixes MEDIAWIKI-CC8
This PR was automatically generated by Sentry. You can adjust this setting at any time.