Fix: Eliminate SimpleBlogPage paginator TypeError race condition - #16
Open
sentry[bot] wants to merge 1 commit into
Open
Fix: Eliminate SimpleBlogPage paginator TypeError race condition#16sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
TypeError: this.paginator.init is not a functionerror (MEDIAWIKI-2J4) which was caused by a race condition in the compatibility shim introduced in PR #11.Root Cause:
The original fix attempted to patch
OOJSPlus.ui.data.pagination.Paginator.prototype.initusing an asynchronousmw.loader.using('ext.oOJSPlus.data').then(...)call. This created a race condition where SimpleBlogPage's XHR could resolve and callthis.paginator.init()before the asynchronous promise resolved and the patch was applied, leading to theTypeError.Solution:
extension.json: Declaredext.oOJSPlus.dataas a static dependency for theext.wikioasismagic.simpleBlogPageFixmodule. This ensures thatext.oOJSPlus.datais fully loaded and available before the shim module's code begins execution.modules/ext.wikioasismagic.simpleBlogPageFix.js: Removed themw.loader.using().then()wrapper. The prototype patch logic now executes synchronously at the top level of the module.This change guarantees that the
Paginator.prototype.initmethod is patched before SimpleBlogPage can attempt to call it, thereby eliminating the race condition and resolving theTypeError. The PHP hook that injects this module already ensures that SimpleBlogPage (and thus OOJSPlus) is loaded when the shim is active, making the static dependency declaration safe and appropriate.Fixes MEDIAWIKI-2J4
This PR was automatically generated by Sentry. You can adjust this setting at any time.