fix(wbfy): trim redundant comments from generated files - #1246
Merged
Conversation
Move the rationale for the generated hooks and configs into wbfy's own sources
and stop writing it into target repositories: the duplicated `{staged_files}`
notes, the bun.lock normalization walkthrough, the oxlint managed-block notes,
the WB_ENV precedence note in fnox.toml (also removed from existing files) and
the globalStore note in bunfig.toml.
Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Also narrow the legacy WB_ENV comment pattern to the wording wbfy actually wrote, so a project-authored comment with the same opening words survives. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
…ing section Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Take main's wording for the comment cleanup landed by #1245; this branch keeps the fnox.toml WB_ENV comment removal and its tests. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
exKAZUu
changed the title
exKAZUu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Summary
wbfyno longer adds the explanatory comment aboutWB_ENVto a repository'sfnox.toml, and it removes the comment previous versions had written there.WB_ENV/NEXT_PUBLIC_WB_ENVvalues themselves, other comments, and the file's formatting stay exactly as they are.Technical Summary
insertWbEnvIntoFnoxToml(packages/wbfy/src/generators/wbEnv.ts) no longer insertswbEnvComment, and the previous "rewrite the outdated wording" migration became a removal: any line matching/^# CI sets WB_ENV as a process env var, which wins over fnox[^\n]*\n/muis deleted, so every wording variant earlier versions wrote converges on a comment-free section.gflag is sufficient because prior versions only ever wrote the comment once, for thedevelopmentmode.lefthook.yml,oxlint.config.tsandbunfig.tomlcomments; fix(wbfy): stop emitting explanatory comments into generated files #1245 landed that cleanup onmainfirst, somainwas merged and its wording kept, leaving only thefnox.tomlpart here.Why
wb's ownWB_ENVprecedence rules inside a file of a target repository — in-house tool specifications must not be documented outside the tool's own package, and the rationale now lives in wbfy's sources.Testing
bun run verify-full(install, lint/format,tsc --noEmit, all tests) — passed after the merge withmain.