CI: report real job results in the build notification - #116
Merged
Conversation
The `notification` job passed `job-results` as a comma-separated list. Wire-Network/notification-action word-splits that input on whitespace and matches each word against `^([^:]+):([^:]+)$`, so a comma-separated list arrives as a single multi-colon word, matches nothing, and parses to `{}`. Every status probe against `{}` is false, so the action fell through to its `else` branch and posted `✅ SUCCESS` to Mattermost regardless of what the jobs did — the status in the message was never derived from the inputs at all.
Switch to the space-separated form the action actually parses. JSON is not a usable alternative here: the action interpolates the input unquoted into a double-quoted shell assignment, which strips the inner quotes and yields invalid JSON that fails the same way.
The reported set and the skipped-to-success mapping for `build-platforms` are unchanged, as is the `all-passing` gate — only the delimiter was wrong.
jglanz
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
notificationjob passedjob-resultsas a comma-separated list. Wire-Network/notification-action word-splits that input on whitespace and matches each word against^([^:]+):([^:]+)$, so a comma-separated list arrives as a single multi-colon word, matches nothing, and parses to{}. Every status probe against{}is false, so the action fell through to itselsebranch and posted✅ SUCCESSto Mattermost regardless of what the jobs did — the status in the message was never derived from the inputs at all.The most recent run on master shows this directly: its notification log reads
Result: {}andOverall: SUCCESS. Everything genuinely did pass there, so the message happened to be correct, but it would have read the same had the build failed.The
all-passinggate was never affected; only the chat message was wrong.What changed
job-resultsmoves to the space-separated form the action actually parses. JSON is not a usable alternative: the action interpolates the input unquoted into a double-quoted shell assignment, which strips the inner quotes and yields invalid JSON that fails in exactly the same way.The reported set, the skipped-to-success mapping for
build-platforms, and theall-passinggate are unchanged — only the delimiter was wrong. The comment claiming the comma form matched wire-sysio is dropped; that repository had the same defect and is fixed in Wire-Network/wire-sysio#602.Relationship to the action fix
Wire-Network/notification-action#1 makes the action accept commas and fail closed, which fixes this repository's notifications on its own. The two changes are deliberately redundant so neither has to land first. This repository tracks the action by
@v1, so it also picks up that fix once the tag is moved.