fix: use uint8_t* for SO_KEEPALIVEAUTO getter (AUD-002) - #181
Open
occamsshavingkit wants to merge 1 commit into
Open
fix: use uint8_t* for SO_KEEPALIVEAUTO getter (AUD-002)#181occamsshavingkit wants to merge 1 commit into
occamsshavingkit wants to merge 1 commit into
Conversation
The getter at socket.c:1383 wrote through uint16_t*, but the setter at socket.c:1334 and the documented type at socket.h:583 both use uint8_t. A conforming caller passing uint8_t had one adjacent byte overwritten and could trigger an unaligned halfword fault on strict-alignment MCUs.
niansa
added a commit
to niansa/ioLibrary_Driver
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes type-width mismatch in the
SO_KEEPALIVEAUTOsocket option getter.Problem
Ethernet/socket.c:1383wrote the keepalive auto value throughuint16_t*:But the setter at
socket.c:1334and the documented type atsocket.h:583both useuint8_t. A conforming caller passinguint8_t valuehas one adjacent byte overwritten and may trigger an unaligned halfword fault on strict-alignment MCUs.Fix
Change
uint16_t*touint8_t*:Verification
_WIZCHIP_values