fix(W5500): correct PHYCFGR OPMDC macro name and handle ALLA case - #185
Open
R0xyLee wants to merge 1 commit into
Open
fix(W5500): correct PHYCFGR OPMDC macro name and handle ALLA case#185R0xyLee wants to merge 1 commit into
R0xyLee wants to merge 1 commit into
Conversation
Rename PHYCFGR_OPMDC_100FA to PHYCFGR_OPMDC_100HA (100BT Half-duplex Auto) to match the W5500 datasheet naming. Update all references in wizphy_getphyconf() accordingly. Also add PHYCFGR_OPMDC_ALLA as a case in the speed and duplex switches so that 'all auto' mode is correctly reported as 100Mbps/full-duplex, matching what the PHY would negotiate. Signed-off-by: R0xy <lee.lockhey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename PHYCFGR_OPMDC_100FA to PHYCFGR_OPMDC_100HA (100BT Half-duplex Auto) to match the W5500 datasheet naming. Update all references in wizphy_getphyconf() accordingly.
Also add PHYCFGR_OPMDC_ALLA as a case in the speed and duplex switches so that 'all auto' mode is correctly reported as 100Mbps/full-duplex, matching what the PHY would negotiate.