Skip to content

Fix ISD2115 write skipping and RP2040 unaligned memory access #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notexactlynikhil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ISD2115 write skipping and RP2040 unaligned memory access #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions isd1200.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ void isd1200_flash_read(uint32_t page, uint8_t *buffer)

uint32_t offset = page * 512;

*(uint32_t *)&buf[1] = __builtin_bswap32(offset << 8);
buf[1] = (offset >> 16) & 0xFF;
buf[2] = (offset >> 8) & 0xFF;
buf[3] = offset & 0xFF;

nuvoton_spi_transfer(buf, sizeof(buf));

Expand All @@ -175,7 +177,9 @@ void isd1200_flash_write(uint32_t page, uint8_t *buffer)

uint32_t offset = page * 16;

*(uint32_t *)&buf[1] = __builtin_bswap32(offset << 8);
buf[1] = (offset >> 16) & 0xFF;
buf[2] = (offset >> 8) & 0xFF;
buf[3] = offset & 0xFF;

memcpy(&buf[4], buffer, 16);

Expand Down
2 changes: 1 addition & 1 deletion spi.pio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ bitloop:
out pins, 1 side 0x2
mov x, y side 0x2
in pins, 1 side 0x0
jmp !osre byteloop side 0x0
jmp !osre byteloop side 0x0 [31]

public entry_point: ; Must set X,Y to n-2 before starting!
pull ifempty side 0x1 [1] ; Block with CSn high (minimum 2 cycles)
Expand Down