Skip to content

Implement Max Flow Scaling for Chord Chart - #2

Draft
google-labs-jules[bot] wants to merge 1 commit into
new_data25from
feature/max-flow-scaling
Draft

Implement Max Flow Scaling for Chord Chart#2
google-labs-jules[bot] wants to merge 1 commit into
new_data25from
feature/max-flow-scaling

Conversation

@google-labs-jules

Copy link
Copy Markdown

This feature adds a new visualization mode to the chord chart. When the "Use Max Flow for Arc Scale" checkbox is enabled, the outer arcs of the chart are rendered to their all-time maximum value. The ribbons for the selected year are then scaled proportionally and aligned within these larger arcs. This allows for a more intuitive comparison of migration flows across different years, as the arc sizes remain consistent.


PR created automatically by Jules for task 7709787922082649106 started by @X80110

This feature introduces a new mode to the chord chart where the outer arcs are scaled to their all-time maximum size, while the inner ribbons for the selected year are proportionally scaled and aligned within those larger arcs.

The `scaleChordLayout` function in `chord-chart.js` now correctly calculates group sizes based on the provided `maxFlows` and then resizes and repositions the chords to fit within these new, larger group arcs. The logic correctly leaves blank space on the arc if the current year's total flow is less than the maximum.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants