Implement Max Flow Scaling for Chord Diagram - #3
Conversation
This commit introduces a new feature that allows users to scale the chord diagram arcs based on the maximum historical flow for each region. This provides a stable visual comparison across different time periods. The feature is controlled by a "Use Max Flow for Arc Scale" checkbox. When enabled, the chord diagram's arcs are scaled to their maximum historical size, and the chords are scaled proportionally to the current year's flow. When disabled, the chart reverts to its original behavior. This implementation includes: - A `scaleChordLayout` function to calculate the scaled chord and group layouts. - A `baseLayout` created from `chordData.maxFlows` to provide a stable reference for arc sizes. - Conditional logic in the `drawChords` function to switch between scaled and non-scaled layouts. - A workaround for a bug in the custom `chord.js` library that caused errors with diagonal matrices.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change implements the feature in index2.html of scaling the geometries according the scale-toggle parameter selection in index.html into the chord-chart.js. It also includes a workaround for a bug in the custom chord.js library.
PR created automatically by Jules for task 13726369615032749572 started by @X80110