decomp 2 sets of spu buffer loading funcs. 1 for mono, 1 for stereo. - #144
decomp 2 sets of spu buffer loading funcs. 1 for mono, 1 for stereo.#144david-martin wants to merge 1 commit into
Conversation
a94d5d1 to
b60cd97
Compare
| SpuSetTransferStartAddr(0x77000); | ||
| func_80038F04(D_80062FE0, 0x1000); | ||
| SpuSetIRQ(0); | ||
| if ((u32)D_80063004 >= 0x1001U) { |
There was a problem hiding this comment.
Sounds like type of D_80063004 should just be u32?
Xeeynamo
left a comment
Xeeynamo
left a comment
There was a problem hiding this comment.
Welcome back David :)
I left a few comments.
| SpuSetTransferStartAddr(0x77000); | ||
| func_80038F04(D_80062FE0, 0x1000); | ||
| SpuSetIRQ(0); | ||
| if ((u32)D_80063004 >= 0x1001U) { |
There was a problem hiding this comment.
| if ((u32)D_80063004 >= 0x1001U) { | |
| if (D_80063004 > 0x1000) { |
I think D_80063004 was a real unsigned. You would need to change the type to u32
| SpuSetIRQ(0); | ||
| if ((u32)D_80063004 >= 0x1001U) { | ||
| SpuSetIRQAddr(0x77000); | ||
| SpuSetIRQCallback(&AkaoStreamIrqCallbackMono1); |
There was a problem hiding this comment.
| SpuSetIRQCallback(&AkaoStreamIrqCallbackMono1); | |
| SpuSetIRQCallback(AkaoStreamIrqCallbackMono1); |
Functions are already treated as pointers when passed as parameter, so & is not required. Same applies to the other proposed changes in this PR
| SpuSetIRQ(0); | ||
| SpuSetVoiceLoopStartAddr(0x10, 0x77000); | ||
| SpuSetVoiceLoopStartAddr(0x11, 0x77800); | ||
| if ((u32)D_80063004 >= 0x1001U) { |
There was a problem hiding this comment.
| if ((u32)D_80063004 >= 0x1001U) { | |
| if (D_80063004 >= 0x1000) { |
see https://github.com/Xeeynamo/ff7-decomp/pull/144/changes#r3945485864
| SpuSetIRQ(0); | ||
| SpuSetVoiceLoopStartAddr(0x10, 0x78000); | ||
| SpuSetVoiceLoopStartAddr(0x11, 0x78800); | ||
| if ((u32)D_80063004 >= 0x1001U) { |
There was a problem hiding this comment.
| if ((u32)D_80063004 >= 0x1001U) { | |
| if (D_80063004 >= 0x1000) { |
Signed-off-by: David Martin <irldavem@gmail.com>
b60cd97 to
8caf300
Compare
Thanks. |
3 participants
Unable to find when these actually get called, if at all, while debugging.