battle.c: decompile the item-drop roll and action sound dispatch - #145
Closed
devcheckra1n wants to merge 1 commit into
Closed
battle.c: decompile the item-drop roll and action sound dispatch#145devcheckra1n wants to merge 1 commit into
devcheckra1n wants to merge 1 commit into
Conversation
devcheckra1n
force-pushed
the
battlefunc4
branch
from
September 7, 2026 04:28
10ffc7b to
f7027f1
Compare
Contributor
Author
|
closing for now, not ready to open this yet, keeping the work on the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more battle.c functions, rebased onto current main now that #129 landed.
The item-drop roll needed
SceneEnemy's trailing padding split intoitemRate[4]/itemId[4]-- the drop chance and item id per slot were sitting in what used to be one opaqueunk90blob.