Deferrs halt plugin config until run_start for full ELF - #113
Merged
Merged
Conversation
jvillarre
self-requested a review
September 8, 2026 20:04
jvillarre
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the proper fix the AieHalt plugin with full elf flow.
The latching of mHwCtxImpl no longer needs to be delayed until after the plugin is configured, but configuration does need to be deferred until the first user run.
This avoids the both the problem of the hw context initially being empty, and also a double lock on the hw context mutex (which the previous change did not address)
It requires changes to XRT to become functional (it needs to actually call runStartImpl), but non full elf flow should not be affected