add a error if TRACE appears in user generated ctrlcode. TRACE is for internal consumption by CERT. - #360
Open
HimanshuChoudhary-Xilinx wants to merge 3 commits into
Open
Conversation
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds assembler rejection for user-authored TRACE opcodes, with a negative test and ISA documentation updates.
Changes:
- Rejects
TRACEduring assembly. - Adds and registers a negative test.
- Updates YAML, Markdown, and HTML specifications.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Summary |
|---|---|
test/aie2ps-ctrlcode/opcode_checks/trace_in_ctrlcode.asm |
Adds invalid TRACE input coverage. |
test/aie2ps-ctrlcode/opcode_checks/CMakeLists.txt |
Registers the negative test; should verify the expected diagnostic with PASS_REGULAR_EXPRESSION. |
test/aie2ps-ctrlcode/CMakeLists.txt |
Includes opcode checks. |
src/cpp/preprocessor/asm/asm_parser.cpp |
Rejects user-generated TRACE opcodes. |
specification/aie2ps/isa-spec.yaml |
Documents the restriction; contains thorw typo. |
specification/aie2ps/isa-spec.md |
Documents the restriction; contains thorw typo. |
specification/aie2ps/isa-spec.html |
Updates generated documentation; contains thorw typo. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| add_test(NAME "${TEST_NAME}" | ||
| COMMAND aiebu-asm -t aie2ps -o aie_control.elf -c "${CMAKE_CURRENT_SOURCE_DIR}/${ASM_FILE}" | ||
| WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | ||
| set_tests_properties("${TEST_NAME}" PROPERTIES WILL_FAIL TRUE) |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Add a error if TRACE appears in user generated ctrlcode. TRACE is for internal consumption by CERT.
Added testcase
Updated Spec
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)